Review main Merged

85086[BUGFIX] Ensure correct column type in database compare for SQLite

Stefan Bürk CR +2 V +2 Easy +14 −9 updated 07/02/24, 17:56

Commit message

Since Doctrine DBAL 4 field types are no longer communicated based
upon column comments [1]. Database vendors not supporting certain
types, for example JSON in case of SQLite, the type retrieved from
reading the database schema does not match when compared with the
virtual database column type. Doctrine internally mitigates this by
using a new way of comparing the compatible create
statements for the database vendor.

Sadly, this comparison has been disabled and circumvented during
the Doctrine DBAL 4 upgrade and still cannot be removed until open
issues have been properly integrated.

This change modifies the virtual structure normalization for SQLite
to change JSON column types to TEXT column types, restoring correct
comparability again.

Note that this a needed normalization based on the blocked Doctrine
DBAL 4 way of comparison.

The exclusion for two system extensions in the full database clear-schema-migration
test is removed along the way.

[1] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-removed-platform-commented-type-api

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Stefan Bürk uploaded patch set 1 07/02/24, 17:09

  2. core-ci voted on patch set 1 V +1 07/02/24, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60854

  3. Garvin Hicking updated the commit message in patch set 2 V +1 07/02/24, 17:43

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 07/02/24, 17:44

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 07/02/24, 17:45

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 07/02/24, 17:47

  7. core-ci voted on patch set 2 V +1 07/02/24, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60856

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 07/02/24, 17:56

  9. Stefan Bürk merged patch set 3 07/02/24, 17:56