Review main Merged

85088[TASK] Improve UX and functionality of "Linkvalidator" report table

Jasmina Ließmann CR +2 V +2 Hard +364 −104 updated 07/24/24, 10:04

Commit message

The report table contains broken links that exist in the system
depending on the configuration. The information about these broken
links can be varied and the previous view already provided essential
information. With this patch the view has been expanded and the UX has
been improved.

Information about the link text, (location) path in the page tree and
the record field that contains the broken link have been moved to a
modal so that the table only contains the relevant information and
further information can be viewed in the modal.

The new modal is divided into an area with information about the link
properties and an area with extensive information about the record
itself.

Furthermore a column has been added to the table that shows the
language of the record that contains the broken link.

Previously, the record icon was simply the standard icon of the table,
now the actual record type is taken into account as the icon.

A sorting function has also been added to the table with which the
columns can be sorted alphabetically in ascending/descending order.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 3044

Show 1119 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 07/02/24, 18:00

  2. core-ci voted on patch set 1 V +1 07/02/24, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60859

  3. Jasmina Ließmann uploaded patch set 2 V +1 07/04/24, 21:56

  4. Jasmina Ließmann uploaded patch set 3 07/04/24, 22:00

  5. core-ci voted on patch set 2 V +1 07/04/24, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60992

  6. core-ci voted on patch set 3 V +1 07/04/24, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60993

  7. Jasmina Ließmann updated the commit message in patch set 4 V +1 07/06/24, 19:18

  8. core-ci voted on patch set 4 V +1 07/06/24, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61101

  9. Jasmina Ließmann uploaded patch set 5 V +1 07/06/24, 19:24

  10. Jasmina Ließmann uploaded patch set 6 07/06/24, 19:29

  11. core-ci voted on patch set 5 V +1 07/06/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61102

  12. Riccardo De Contardi commented on patch set 5 07/06/24, 19:32

    ReportTable.html:57

    Maybe it is just a nitpick from me, but: could the icon be omitted? I mean, they're all error messages, right? AFAICS the icon is always present and is always the same,so why repeat it for every line? I'd like to know the opinion of others.
  13. core-ci voted on patch set 6 V +1 07/06/24, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61103

  14. Jasmina Ließmann uploaded patch set 7 V +1 07/06/24, 19:36

  15. Jasmina Ließmann commented on patch set 7 07/06/24, 19:37

    ReportTable.html:57 Reply

    I was inspired by the "Log" backend module, but have now removed the icon as suggested.
  16. core-ci voted on patch set 7 V +1 07/06/24, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61104

  17. Jasmina Ließmann updated the commit message in patch set 8 V +1 07/06/24, 20:58

  18. core-ci voted on patch set 8 V +1 07/06/24, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61111

  19. Jasmina Ließmann uploaded patch set 9 V +1 07/06/24, 21:14

  1. core-ci voted on patch set 9 V +1 07/06/24, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61112

  2. Riccardo De Contardi commented on patch set 7 07/06/24, 21:23

    ReportTable.html:57 Reply

    Sorry for the late answer. You could also see it in another way: are there errors that are more severe and so require more attention than others? They deserve to have an icon to catch attention ;)
  3. Christian Kuhn uploaded patch set 10 V +1 07/06/24, 21:41

  4. Jasmina Ließmann commented on patch set 10 07/06/24, 21:45

    ReportTable.html:57 Reply

    Unfortunately, all error messages are passed together in one variable. It is therefore not possible to differentiate between the messages.
  5. core-ci voted on patch set 10 V -1 07/06/24, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61113

  6. Christian Kuhn uploaded patch set 11 V -1 07/06/24, 21:47

  7. Christian Kuhn voted on patch set 11 CR +1 V +1 07/06/24, 21:50

  8. core-ci voted on patch set 11 V +1 07/06/24, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61114

  9. Oli Bartsch commented on patch set 11 07/07/24, 10:39

    linkvalidator-modal.ts:18

    Please let's make a web component here

    linkvalidator.ts:43

    Why do we not check for the instance above already?
  10. Garvin Hicking commented on patch set 11 07/07/24, 16:05

    In my Macbook even though I run at fullscreen sadly exactly the "modal popup" (i) icon is not displayed in the table row. Space there is scarce, but due to the horizontal scrollbars only appear at the bottom, people may not see that new modal popup at all. How about putting it as the first table cell or is there another way, like putting the three buttons above each other instead next to each other, when there's too little space? Screenshot: https://capture.dropbox.com/Imh8NSeq472rlEcu

    ReportTable.html:182

    This makes EXT:styleguide tree fail. I've validated a tx_styleguide_elements_basic array of link_1 to link_5, and then I get an extbase error: ``` ViewHelper f:translate in non-extbase context needs attribute "extensionName" to resolve key="Form engine elements - input, text, uuid, checkbox, radio, none, passthrough, user" without path. Either set attribute "extensionName" together with the short key "yourKey" to result in a lookup "LLL:EXT:your_extension/Resources/Private/Language/locallang.xlf:yourKey", or (better) use a full LLL reference like key="LLL:EXT:your_extension/Resources/Private/Language/yourFile.xlf:yourKey". Alternatively, you can also define a default value. ``` I think this happens because `$GLOBALS['TCA'][$table]['ctrl']['title']` can sometimes be empty and then f:translate chokes. Also, sadly, this value can contain a fixed string and not a LLL:EXT reference. So I'm thinking we need to translate that items directly in the Controller to make the logic easier (else fluid would need to check if the string starts with "EXT:LLL" or it would need to supply an "extensionName" here, but then you would need to infer the extension name from the TCA, which is hard I guess?
  11. Jasmina Ließmann rebased onto patch set 12 CR +1 V +1 07/24/24, 07:49

  12. core-ci voted on patch set 12 V +1 07/24/24, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62074

  13. Jasmina Ließmann commented on patch set 12 07/24/24, 07:59

    linkvalidator-modal.ts:18 Reply

    I would like to consider the creation of a web component separately from this patch. Feel free to create a pre-patch, otherwise the web component can be created afterwards and the markup in EXT:linkvalidator can then be adjusted accordingly.

    linkvalidator.ts:43 Reply

    I based myself on the following script: `/typo3-core/Build/Sources/TypeScript/extensionmanager/main.ts` Feel free to adapt the query.
  14. Jasmina Ließmann commented on patch set 12 07/24/24, 08:13

    linkvalidator-modal.ts:18 Reply

    As addition: I based the implementation of the modal on EXT:dashboard. This part could also be adjusted once the web component has been created (as I said, more likely in a follow patch).
  15. Jasmina Ließmann uploaded patch set 13 V +1 07/24/24, 08:19

  16. Jasmina Ließmann commented on patch set 13 07/24/24, 08:23

    ReportTable.html:182 Reply

    I have updated the implementation accordingly.
  17. core-ci voted on patch set 13 V +1 07/24/24, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62077

  18. Garvin Hicking commented on patch set 13 07/24/24, 08:50

    LinkValidatorController.php:361

    How about maybe using: ``` 'recordTableTitle' => ($languageService->sL($GLOBALS['TCA'][$table]['ctrl']['title'] ?? '') ?? $table), ``` here to have the table name as fallback? (untested)
  19. Jasmina Ließmann uploaded patch set 14 V +1 07/24/24, 09:22

  20. Jasmina Ließmann commented on patch set 13 07/24/24, 09:23

    LinkValidatorController.php:361 Reply

    Good idea! Since I already have the variable available in the template, I implemented the fallback via Fluid.
  21. core-ci voted on patch set 14 V +1 07/24/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62080

  22. Garvin Hicking commented on patch set 14 CR +1 V +1 07/24/24, 09:44

    Seems to work well for me now!
  23. Christian Kuhn voted on patch set 14 CR +1 V +1 07/24/24, 09:55

  24. Jasmina Ließmann voted on patch set 14 CR +2 V +2 07/24/24, 10:04

  25. Jasmina Ließmann merged patch set 15 07/24/24, 10:04