85088[TASK] Improve UX and functionality of "Linkvalidator" report table
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/linkvalidator/linkvalidator-modal.ts3new+45 −0
- Build/Sources/TypeScript/linkvalidator/linkvalidator.ts2+13 −1
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php2+38 −10
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+7 −7
- typo3/sysext/linkvalidator/Resources/Private/Language/Module/locallang.xlf+58 −44
- typo3/sysext/linkvalidator/Resources/Private/Partials/ReportTable.html6+185 −40
- typo3/sysext/linkvalidator/Resources/Private/Templates/Backend/Report.html+4 −1
- typo3/sysext/linkvalidator/Resources/Public/JavaScript/linkvalidator-modal.jsnew+13 −0
- typo3/sysext/linkvalidator/Resources/Public/JavaScript/linkvalidator.js+1 −1
Review log 3044
Show 1119 earlier messages
-
Jasmina Ließmann uploaded patch set 1 07/02/24, 18:00
-
core-ci voted on patch set 1 V +1 07/02/24, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60859
-
Jasmina Ließmann uploaded patch set 2
V +107/04/24, 21:56 -
Jasmina Ließmann uploaded patch set 3 07/04/24, 22:00
-
core-ci voted on patch set 2 V +1 07/04/24, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60992
-
core-ci voted on patch set 3 V +1 07/04/24, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60993
-
Jasmina Ließmann updated the commit message in patch set 4
V +107/06/24, 19:18 -
core-ci voted on patch set 4 V +1 07/06/24, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61101
-
Jasmina Ließmann uploaded patch set 5
V +107/06/24, 19:24 -
Jasmina Ließmann uploaded patch set 6 07/06/24, 19:29
-
core-ci voted on patch set 5 V +1 07/06/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61102
-
Riccardo De Contardi commented on patch set 5 07/06/24, 19:32
-
core-ci voted on patch set 6 V +1 07/06/24, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61103
-
Jasmina Ließmann uploaded patch set 7
V +107/06/24, 19:36 -
Jasmina Ließmann commented on patch set 7 07/06/24, 19:37
ReportTable.html:57ReplyI was inspired by the "Log" backend module, but have now removed the icon as suggested. -
core-ci voted on patch set 7 V +1 07/06/24, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61104
-
Jasmina Ließmann updated the commit message in patch set 8
V +107/06/24, 20:58 -
core-ci voted on patch set 8 V +1 07/06/24, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61111
-
Jasmina Ließmann uploaded patch set 9
V +107/06/24, 21:14
-
core-ci voted on patch set 9 V +1 07/06/24, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61112
-
Riccardo De Contardi commented on patch set 7 07/06/24, 21:23
ReportTable.html:57ReplySorry for the late answer. You could also see it in another way: are there errors that are more severe and so require more attention than others? They deserve to have an icon to catch attention ;) -
Christian Kuhn uploaded patch set 10
V +107/06/24, 21:41 -
Jasmina Ließmann commented on patch set 10 07/06/24, 21:45
ReportTable.html:57ReplyUnfortunately, all error messages are passed together in one variable. It is therefore not possible to differentiate between the messages. -
core-ci voted on patch set 10 V -1 07/06/24, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61113
-
Christian Kuhn uploaded patch set 11
V -107/06/24, 21:47 -
Christian Kuhn voted on patch set 11 CR +1 V +1 07/06/24, 21:50
-
core-ci voted on patch set 11 V +1 07/06/24, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61114
-
Oli Bartsch commented on patch set 11 07/07/24, 10:39
linkvalidator-modal.ts:18Please let's make a web component herelinkvalidator.ts:43Why do we not check for the instance above already? -
Garvin Hicking commented on patch set 11 07/07/24, 16:05
In my Macbook even though I run at fullscreen sadly exactly the "modal popup" (i) icon is not displayed in the table row. Space there is scarce, but due to the horizontal scrollbars only appear at the bottom, people may not see that new modal popup at all. How about putting it as the first table cell or is there another way, like putting the three buttons above each other instead next to each other, when there's too little space? Screenshot: https://capture.dropbox.com/Imh8NSeq472rlEcuReportTable.html:182This makes EXT:styleguide tree fail. I've validated a tx_styleguide_elements_basic array of link_1 to link_5, and then I get an extbase error: ``` ViewHelper f:translate in non-extbase context needs attribute "extensionName" to resolve key="Form engine elements - input, text, uuid, checkbox, radio, none, passthrough, user" without path. Either set attribute "extensionName" together with the short key "yourKey" to result in a lookup "LLL:EXT:your_extension/Resources/Private/Language/locallang.xlf:yourKey", or (better) use a full LLL reference like key="LLL:EXT:your_extension/Resources/Private/Language/yourFile.xlf:yourKey". Alternatively, you can also define a default value. ``` I think this happens because `$GLOBALS['TCA'][$table]['ctrl']['title']` can sometimes be empty and then f:translate chokes. Also, sadly, this value can contain a fixed string and not a LLL:EXT reference. So I'm thinking we need to translate that items directly in the Controller to make the logic easier (else fluid would need to check if the string starts with "EXT:LLL" or it would need to supply an "extensionName" here, but then you would need to infer the extension name from the TCA, which is hard I guess? -
Jasmina Ließmann rebased onto patch set 12
CR +1V +107/24/24, 07:49 -
core-ci voted on patch set 12 V +1 07/24/24, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62074
-
Jasmina Ließmann commented on patch set 12 07/24/24, 07:59
linkvalidator-modal.ts:18ReplyI would like to consider the creation of a web component separately from this patch. Feel free to create a pre-patch, otherwise the web component can be created afterwards and the markup in EXT:linkvalidator can then be adjusted accordingly.linkvalidator.ts:43ReplyI based myself on the following script: `/typo3-core/Build/Sources/TypeScript/extensionmanager/main.ts` Feel free to adapt the query. -
Jasmina Ließmann commented on patch set 12 07/24/24, 08:13
linkvalidator-modal.ts:18ReplyAs addition: I based the implementation of the modal on EXT:dashboard. This part could also be adjusted once the web component has been created (as I said, more likely in a follow patch). -
Jasmina Ließmann uploaded patch set 13
V +107/24/24, 08:19 -
Jasmina Ließmann commented on patch set 13 07/24/24, 08:23
ReportTable.html:182ReplyI have updated the implementation accordingly. -
core-ci voted on patch set 13 V +1 07/24/24, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62077
-
Garvin Hicking commented on patch set 13 07/24/24, 08:50
LinkValidatorController.php:361How about maybe using: ``` 'recordTableTitle' => ($languageService->sL($GLOBALS['TCA'][$table]['ctrl']['title'] ?? '') ?? $table), ``` here to have the table name as fallback? (untested) -
Jasmina Ließmann uploaded patch set 14
V +107/24/24, 09:22 -
Jasmina Ließmann commented on patch set 13 07/24/24, 09:23
LinkValidatorController.php:361ReplyGood idea! Since I already have the variable available in the template, I implemented the fallback via Fluid. -
core-ci voted on patch set 14 V +1 07/24/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62080
-
Garvin Hicking commented on patch set 14 CR +1 V +1 07/24/24, 09:44
Seems to work well for me now! -
Christian Kuhn voted on patch set 14 CR +1 V +1 07/24/24, 09:55
-
Jasmina Ließmann voted on patch set 14 CR +2 V +2 07/24/24, 10:04
-
Jasmina Ließmann merged patch set 15 07/24/24, 10:04
ReportTable.html:57