Review main Merged

85092[TASK] Bundle Flex DS check,migrate,prepare

Christian Kuhn CR +2 V +2 Hard +308 −487 updated 07/03/24, 13:41

Commit message

Central single flex datastructure field TCA
migration and preparation has been established
with #104293.

This patch refactors the code another time to
avoid a recursion, merges the two traverse
operations into one construct, and checks
for not supported data structure setups like
section containers defining TCA types with
DB relations.

Those checks for invalid data structures were
previously located within FormEngine related
TcaFlexProcess, and are now relocated to the
more central FlexFormTools.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 1116

  1. Christian Kuhn uploaded patch set 1 07/03/24, 08:59

  2. core-ci voted on patch set 1 V +1 07/03/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60894

  3. Christian Kuhn uploaded patch set 2 V +1 07/03/24, 09:13

  4. Christian Kuhn updated the commit message in patch set 3 07/03/24, 09:15

  5. Christian Kuhn updated the commit message in patch set 4 07/03/24, 09:20

  6. core-ci voted on patch set 2 V +1 07/03/24, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60895

  7. core-ci voted on patch set 3 V +1 07/03/24, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60896

  8. core-ci voted on patch set 4 V +1 07/03/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60898

  9. Oli Bartsch commented on patch set 4 V -1 07/03/24, 10:18

    FlexFormTools.php:634

    Array to string conversion
  10. Oli Bartsch uploaded patch set 5 V +1 07/03/24, 10:19

  11. Oli Bartsch commented on patch set 5 CR +1 V +1 07/03/24, 10:19

    FlexFormTools.php:634 Reply

    Done
  12. core-ci voted on patch set 5 V +1 07/03/24, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60900

  13. Christian Kuhn commented on patch set 5 07/03/24, 11:52

    FlexFormTools.php:634 Reply

    good catch! thx!
  14. Garvin Hicking voted on patch set 5 CR +1 V +1 07/03/24, 12:25

  15. Christian Kuhn voted on patch set 5 CR +2 V +2 07/03/24, 13:41

  16. Christian Kuhn merged patch set 6 07/03/24, 13:41