85098[TASK] Add distinct warning when CType element preview has no label
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Karsten Nowak +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php+1 −1
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php+1 −1
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+3 −3
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf7+3 −0
Review log 1517
-
Garvin Hicking uploaded patch set 1 07/03/24, 18:06
-
Garvin Hicking commented on patch set 1 07/03/24, 18:07
Screenshots before/after in the forge ticket: https://forge.typo3.org/issues/104299 -
core-ci voted on patch set 1 V -1 07/03/24, 18:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60921
-
Garvin Hicking uploaded patch set 2
V -107/03/24, 18:29Massage tests -
core-ci voted on patch set 2 V +1 07/03/24, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60924
-
Georg Ringer commented on patch set 2 07/04/24, 05:59
locallang_core.xlf:415IMO no need to have it all in upper case -
Garvin Hicking commented on patch set 2 07/04/24, 06:01
locallang_core.xlf:415ReplyHm, I wanted to keep this consistent to the other warning? With small letters it might not be a striking warning...? -
Oliver Klee commented on patch set 2 07/04/24, 07:41
locallang_core.xlf:415ReplyMaybe we can do it like this: 1. keep it in uppercase in this change 2. do a dedicated follow-up change to change the labels to use normal casing (instead of shouting) ;-) Then we'll have both consistency as well as nice, focused small changes. What do you two think? -
Garvin Hicking commented on patch set 2 07/04/24, 07:54
locallang_core.xlf:415ReplyBUT I LIKE THE SHOUTING! -
Oliver Klee commented on patch set 2 07/04/24, 08:01
locallang_core.xlf:415Reply(me turning my hearing aid off and slowly walking away while shaking my cane at you and mumbling something about today's younglings) ;-) -
Karsten Nowak commented on patch set 2 CR +1 07/05/24, 15:01
locallang_core.xlf:415ReplyAs I see in v13 is no longer an error message shown, just the plugin name is used. That was the result of my review in main. Perhaps this makes the discussion about capitalisation unnecessary? :-) For me both of them is ok. A proper message or just the pluign name. Important for me is, that no wrong warning with about "invalid" value is visible. -
Garvin Hicking commented on patch set 2 07/05/24, 15:25
locallang_core.xlf:415ReplyI would like to preserve the UPPERCASE as it currently stands. Making this different should then be made for both the INVALID VALUE and MISSING LABEL and in a follow-up change. I hope that is okay and I'm resolving this to push things forward. VOTES WELCOME. ;-) -
Georg Ringer voted on patch set 2 CR +1 V +1 07/05/24, 18:43
-
Christian Kuhn voted on patch set 2 CR +1 V +1 07/11/24, 22:24
-
Oliver Klee wrote 07/11/24, 22:46
Removed cc Oliver Klee. -
Christian Kuhn voted on patch set 2 CR +2 V +2 07/12/24, 13:47
-
Christian Kuhn merged patch set 3 07/12/24, 13:47