Review main Merged

85098[TASK] Add distinct warning when CType element preview has no label

Garvin Hicking CR +2 V +2 Easy +8 −5 updated 07/12/24, 13:47

Commit message

When a CType content element is registered with an empty label,
the page preview of that element showed a warning:

  INVALID VALUE ("myPlugin")

which is actually misleading, because not the value itself is
wrong, but the label is missing.

A new language variable is introduced to distinguish the difference
of this misconfiguration issue, and now emits:

  MISSING LABEL ("myPlugin")

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Karsten Nowak +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1517

  1. Garvin Hicking uploaded patch set 1 07/03/24, 18:06

  2. Garvin Hicking commented on patch set 1 07/03/24, 18:07

    Screenshots before/after in the forge ticket: https://forge.typo3.org/issues/104299
  3. core-ci voted on patch set 1 V -1 07/03/24, 18:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60921

  4. Garvin Hicking uploaded patch set 2 V -1 07/03/24, 18:29

    Massage tests
  5. core-ci voted on patch set 2 V +1 07/03/24, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60924

  6. Georg Ringer commented on patch set 2 07/04/24, 05:59

    locallang_core.xlf:415

    IMO no need to have it all in upper case
  7. Garvin Hicking commented on patch set 2 07/04/24, 06:01

    locallang_core.xlf:415 Reply

    Hm, I wanted to keep this consistent to the other warning? With small letters it might not be a striking warning...?
  8. Oliver Klee commented on patch set 2 07/04/24, 07:41

    locallang_core.xlf:415 Reply

    Maybe we can do it like this: 1. keep it in uppercase in this change 2. do a dedicated follow-up change to change the labels to use normal casing (instead of shouting) ;-) Then we'll have both consistency as well as nice, focused small changes. What do you two think?
  9. Garvin Hicking commented on patch set 2 07/04/24, 07:54

    locallang_core.xlf:415 Reply

    BUT I LIKE THE SHOUTING!
  10. Oliver Klee commented on patch set 2 07/04/24, 08:01

    locallang_core.xlf:415 Reply

    (me turning my hearing aid off and slowly walking away while shaking my cane at you and mumbling something about today's younglings) ;-)
  11. Karsten Nowak commented on patch set 2 CR +1 07/05/24, 15:01

    locallang_core.xlf:415 Reply

    As I see in v13 is no longer an error message shown, just the plugin name is used. That was the result of my review in main. Perhaps this makes the discussion about capitalisation unnecessary? :-) For me both of them is ok. A proper message or just the pluign name. Important for me is, that no wrong warning with about "invalid" value is visible.
  12. Garvin Hicking commented on patch set 2 07/05/24, 15:25

    locallang_core.xlf:415 Reply

    I would like to preserve the UPPERCASE as it currently stands. Making this different should then be made for both the INVALID VALUE and MISSING LABEL and in a follow-up change. I hope that is okay and I'm resolving this to push things forward. VOTES WELCOME. ;-)
  13. Georg Ringer voted on patch set 2 CR +1 V +1 07/05/24, 18:43

  14. Christian Kuhn voted on patch set 2 CR +1 V +1 07/11/24, 22:24

  15. Oliver Klee wrote 07/11/24, 22:46

    Removed cc Oliver Klee.
  16. Christian Kuhn voted on patch set 2 CR +2 V +2 07/12/24, 13:47

  17. Christian Kuhn merged patch set 3 07/12/24, 13:47