Review main Merged

85102[TASK] Define cache.assets in service provider

Benjamin Franzke CR +2 V +2 Easy +9 −4 updated 07/04/24, 22:07

Commit message

The cache.assets container entry was pregenerated in Bootstrap
for historic reasons: it used to be statically injected into
the IconRegistry and PageRenderer from Bootstrap::init().

This has been refactored with #93475 and #97030, therefore
assets cache generation can now be delayed until it is actually
needed.

Note: It is needed in uncached installtool context, therefore
it is provided in ServiceProvider.php instead of Services.yaml

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 68

  1. Benjamin Franzke uploaded patch set 1 07/04/24, 10:02

  2. core-ci voted on patch set 1 V +1 07/04/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60956

  3. Benni Mack updated the commit message in patch set 2 V +1 07/04/24, 13:04

  4. Benni Mack voted on patch set 2 CR +1 V +1 07/04/24, 13:04

  5. core-ci voted on patch set 2 V +1 07/04/24, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60970

  6. Georg Ringer voted on patch set 2 CR +2 V +2 07/04/24, 19:54

  7. Georg Ringer merged patch set 3 07/04/24, 19:54

  8. Christian Kuhn commented on patch set 3 07/04/24, 22:07

    Thank you! Great example for the IconRegistry!