Review main Merged

85105[TASK] Add native types to RelationHandler where possible

Benni Mack CR +2 V +2 Normal +59 −144 updated 07/09/24, 15:50

Commit message

This change adds native PHP types to RelationHandler.

The reasoning for the changes:
- Even though some properties are public and not typed,
  setting an array property to null will fatal if Relation
  Handler already expects an array access
- Some methods do not get full types, as some options
  can be string/int etc, whereas $tableName must be a
  string in any case, where a type is applied.

This is a pre-patch as part of a bigger change in order
to bring TcaSchema API and Record API into RelationHandler.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1217

  1. Benni Mack uploaded patch set 1 07/04/24, 15:08

  2. core-ci voted on patch set 1 V -1 07/04/24, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60975

  3. Benni Mack uploaded patch set 2 V -1 07/09/24, 06:49

  4. core-ci voted on patch set 2 V +1 07/09/24, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61209

  5. Benni Mack updated the commit message in patch set 3 V +1 07/09/24, 07:07

  6. core-ci voted on patch set 3 V +1 07/09/24, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61210

  7. Oliver Klee voted on patch set 3 V +1 07/09/24, 07:44

  8. Oliver Klee commented on patch set 3 07/09/24, 07:45

    RelationHandler.php:1243

    `string $purgeCallback` Or if the PHPDoc annotation is incorrect/incomplete (haven't checked), we should fix that.
  9. Christian Kuhn updated the commit message in patch set 4 V +1 07/09/24, 10:41

  10. core-ci voted on patch set 4 V +1 07/09/24, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61222

  11. Christian Kuhn commented on patch set 4 07/09/24, 10:53

    RelationHandler.php:769

    : void

    RelationHandler.php:898

    : void

    RelationHandler.php:1135

    could just return void, the return value is never used anyways. alternative (preferred by me): inline code and remove method.
  12. Christian Kuhn commented on patch set 4 07/09/24, 15:30

    RelationHandler.php:769 Reply

    Done

    RelationHandler.php:898 Reply

    Done

    RelationHandler.php:1135 Reply

    Done

    RelationHandler.php:1243 Reply

    Done
  13. Christian Kuhn uploaded patch set 5 V +1 07/09/24, 15:31

  14. core-ci voted on patch set 5 V +1 07/09/24, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61250

  15. Christian Kuhn voted on patch set 5 CR +1 V +1 07/09/24, 15:38

  16. Georg Ringer voted on patch set 5 CR +2 V +2 07/09/24, 15:50

  17. Georg Ringer merged patch set 6 07/09/24, 15:50