85105[TASK] Add native types to RelationHandler where possible
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1217
-
Benni Mack uploaded patch set 1 07/04/24, 15:08
-
core-ci voted on patch set 1 V -1 07/04/24, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60975
-
Benni Mack uploaded patch set 2
V -107/09/24, 06:49 -
core-ci voted on patch set 2 V +1 07/09/24, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61209
-
Benni Mack updated the commit message in patch set 3
V +107/09/24, 07:07 -
core-ci voted on patch set 3 V +1 07/09/24, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61210
-
Oliver Klee voted on patch set 3 V +1 07/09/24, 07:44
-
Oliver Klee commented on patch set 3 07/09/24, 07:45
-
Christian Kuhn updated the commit message in patch set 4
V +107/09/24, 10:41 -
core-ci voted on patch set 4 V +1 07/09/24, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61222
-
Christian Kuhn commented on patch set 4 07/09/24, 10:53
RelationHandler.php:769: voidRelationHandler.php:898: voidRelationHandler.php:1135could just return void, the return value is never used anyways. alternative (preferred by me): inline code and remove method. -
Christian Kuhn commented on patch set 4 07/09/24, 15:30
RelationHandler.php:769ReplyDoneRelationHandler.php:898ReplyDoneRelationHandler.php:1135ReplyDoneRelationHandler.php:1243ReplyDone -
Christian Kuhn uploaded patch set 5
V +107/09/24, 15:31 -
core-ci voted on patch set 5 V +1 07/09/24, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61250
-
Christian Kuhn voted on patch set 5 CR +1 V +1 07/09/24, 15:38
-
Georg Ringer voted on patch set 5 CR +2 V +2 07/09/24, 15:50
-
Georg Ringer merged patch set 6 07/09/24, 15:50
RelationHandler.php:1243