Review main Merged

85106[BUGFIX] Fix broken Installer when typo3conf dir is missing

Garvin Hicking CR +2 V +2 Easy +3 −1 updated 07/11/24, 22:32

Commit message

With issue #104074 a change was introduced that no longer required
"typo3conf" to exist in composer mode.

Sadly the installer performed a write check on the specific
old "typo3conf" location instead of using the actual
new location for config files since TYPO3 v12.

The installer does not report back FlashMessages on failed
AJAX requests, also those AJAX requests currently oddly
do not even show up in browser's network panel. Without
this, an enduser is not able to finish the installation,
which could be done by just creating an empty
"typo3conf" directory. This should be addressed in a
follow-up, the FlashMessage is already prepared now
to be contained in the JSON response.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Björn Jacob +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 1114

  1. Garvin Hicking uploaded patch set 1 07/04/24, 15:33

  2. core-ci voted on patch set 1 V +1 07/04/24, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60977

  3. Oliver Hader voted on patch set 1 CR +1 07/04/24, 18:29

  4. Björn Jacob commented on patch set 1 07/04/24, 18:40

    I am not sure about this one. The issue does not fit. IMHO this is the review id. Should be the forge issue instead.

    InstallerController.php:203

    Isn't it always "Cannot"?
  5. Oliver Hader updated the commit message in patch set 2 CR +1 V +1 07/04/24, 18:45

  6. Oliver Hader commented on patch set 3 07/04/24, 18:46

    Published edit on patch set 2.
  7. Oliver Hader commented on patch set 3 07/04/24, 18:47

    Reply

    Thx. I've adjusted that...

    InstallerController.php:203 Reply

    Good catch! I overlooked that...
  8. core-ci voted on patch set 2 V +1 07/04/24, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60984

  9. core-ci voted on patch set 3 V +1 07/04/24, 18:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60985

  10. Björn Jacob voted on patch set 3 CR +1 07/04/24, 19:35

  11. Guido Schmechel voted on patch set 3 CR +1 07/04/24, 20:37

  12. Markus Klein voted on patch set 3 CR +1 07/05/24, 06:29

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 07/11/24, 22:32

  14. Christian Kuhn merged patch set 4 07/11/24, 22:32