85106[BUGFIX] Fix broken Installer when typo3conf dir is missing
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Björn Jacob +1
- Guido Schmechel +1
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 2
Files 1
Review log 1114
-
Garvin Hicking uploaded patch set 1 07/04/24, 15:33
-
core-ci voted on patch set 1 V +1 07/04/24, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60977
-
Oliver Hader voted on patch set 1 CR +1 07/04/24, 18:29
-
Björn Jacob commented on patch set 1 07/04/24, 18:40
I am not sure about this one. The issue does not fit. IMHO this is the review id. Should be the forge issue instead.InstallerController.php:203Isn't it always "Cannot"? -
Oliver Hader updated the commit message in patch set 2
CR +1V +107/04/24, 18:45 -
Oliver Hader commented on patch set 3 07/04/24, 18:46
Published edit on patch set 2. -
Oliver Hader commented on patch set 3 07/04/24, 18:47
Reply
Thx. I've adjusted that...InstallerController.php:203ReplyGood catch! I overlooked that... -
core-ci voted on patch set 2 V +1 07/04/24, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60984
-
core-ci voted on patch set 3 V +1 07/04/24, 18:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60985
-
Björn Jacob voted on patch set 3 CR +1 07/04/24, 19:35
-
Guido Schmechel voted on patch set 3 CR +1 07/04/24, 20:37
-
Markus Klein voted on patch set 3 CR +1 07/05/24, 06:29
-
Christian Kuhn voted on patch set 3 CR +2 V +2 07/11/24, 22:32
-
Christian Kuhn merged patch set 4 07/11/24, 22:32