Review main Merged

85111[TASK] Turn workspace HistoryService stateless

Andreas Nedbal CR +2 V +2 Easy +12 −33 updated 07/07/24, 09:41

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Andreas Nedbal uploaded patch set 1 07/05/24, 12:21

  2. core-ci voted on patch set 1 V -1 07/05/24, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61048

  3. Andreas Nedbal uploaded patch set 2 V -1 07/05/24, 12:48

  4. core-ci voted on patch set 2 V +1 07/05/24, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61052

  5. Benni Mack voted on patch set 2 CR +1 V +1 07/05/24, 13:33

  6. Oli Bartsch voted on patch set 2 CR +2 V +2 07/05/24, 14:06

  7. Oli Bartsch merged patch set 3 07/05/24, 14:06

  8. Christian Kuhn commented on patch set 3 07/06/24, 07:17

    post -1: HistoryService is shared (even marked by implementing SingletonInterface), and now gets the stateful DiffUtility injected, plus the heavily stateful RecordHistory.
  9. Anja Leichsenring wrote 07/06/24, 08:52

    Created a revert of this change as Icc7d79443d1e4b348c6416ae24d5aef500a711d6
  10. Christian Kuhn commented on patch set 3 07/07/24, 09:41

    Reply

    reverted for now.