Review main Merged

85132[TASK] Introduce CSS Color Tokens

Benjamin Kott CR +2 V +2 Hard +428 −233 updated 07/08/24, 08:59

Commit message

With this patch, we are introducing color tokens
for use across the system. These tokens are provided
as CSS variables.

We generate the tokens by starting from a base value
and modifying the luminance, rather than shading or
tinting the current color. This approach ensures a
consistent color scheme.

Additionally, we are providing new surface variants
for the general states used in the backend, such as
primary, secondary, danger, and success. These will
be used in components and will back utility classes like
`.bg-<color>` and `.text-bg-<color>`.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 2335

Show 510 earlier messages
  1. Benjamin Kott uploaded patch set 1 07/05/24, 12:46

  2. core-ci voted on patch set 1 V +1 07/05/24, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61051

  3. Benjamin Kott updated the commit message in patch set 2 V +1 07/05/24, 12:56

  4. core-ci voted on patch set 2 V +1 07/05/24, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61053

  5. Benjamin Kott uploaded patch set 3 V +1 07/05/24, 13:21

  6. Benjamin Kott uploaded patch set 4 07/05/24, 13:23

  7. Benjamin Kott uploaded patch set 5 07/05/24, 13:26

  8. core-ci voted on patch set 3 V +1 07/05/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61054

  9. core-ci voted on patch set 4 V +1 07/05/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61055

  10. core-ci voted on patch set 5 V +1 07/05/24, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61056

  1. Benjamin Franzke commented on patch set 5 CR -1 07/05/24, 13:39

    _surface.scss:5

    This should not be public API.

    Surfaces.html:15

    Missing trailing dot.
  2. Benjamin Franzke commented on patch set 5 CR -2 07/05/24, 13:41

    _surface.scss:5 Reply

    No utility classes please.
  3. Benjamin Kott commented on patch set 5 07/05/24, 13:42

    _surface.scss:5 Reply

    as discussed 🖕
  4. Benjamin Franzke commented on patch set 5 07/05/24, 15:06

    _surface.scss:5 Reply

    yup, will adapt 🤗
  5. Benjamin Franzke uploaded patch set 6 V +1 07/05/24, 17:53

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. Benjamin Franzke commented on patch set 6 07/05/24, 17:53

    _surface.scss:5 Reply

    Done

    Surfaces.html:15 Reply

    Done
  7. Benjamin Franzke commented on patch set 6 07/05/24, 17:58

    _main.scss:31

    These values do not match the base values from Build/Sources/Sass/component/_root.scss i guess you picked different shades here, right?
  8. core-ci voted on patch set 6 V +1 07/05/24, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61063

  9. Benjamin Kott uploaded patch set 7 CR +1 V +1 07/08/24, 06:14

  10. core-ci voted on patch set 7 V +1 07/08/24, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61159

  11. Benjamin Kott uploaded patch set 8 V +1 07/08/24, 06:57

  12. Benjamin Kott commented on patch set 8 07/08/24, 06:57

    _main.scss:31 Reply

    Done
  13. core-ci voted on patch set 8 V +1 07/08/24, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61161

  14. Benjamin Kott uploaded patch set 9 V +1 07/08/24, 07:22

  15. core-ci voted on patch set 9 V +1 07/08/24, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61162

  16. Benjamin Kott uploaded patch set 10 V +1 07/08/24, 08:33

  17. Benjamin Kott uploaded patch set 11 07/08/24, 08:39

  18. core-ci voted on patch set 10 V +1 07/08/24, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61165

  19. core-ci voted on patch set 11 V +1 07/08/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61167

  20. Benjamin Kott uploaded patch set 12 V +1 07/08/24, 08:52

  21. Benjamin Franzke voted on patch set 12 CR +1 V +1 07/08/24, 08:53

  22. core-ci voted on patch set 12 V +1 07/08/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61168

  23. Andreas Kienast voted on patch set 12 CR +1 V +1 07/08/24, 08:58

  24. Benjamin Kott voted on patch set 12 CR +2 V +2 07/08/24, 08:59

  25. Benjamin Kott merged patch set 13 07/08/24, 08:59