85137[BUGFIX] Read RTE options as string and array
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benjamin Franzke +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/core/Classes/Html/HtmlParser.php2+14 −6
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+12 −2
- typo3/sysext/core/Tests/Unit/Html/HtmlParserTest.php+0 −2
- typo3/sysext/rte_ckeditor/Tests/Functional/Fixtures/RteConfigArrayFixtureProcessing.yaml+23 −38
- typo3/sysext/rte_ckeditor/Tests/Functional/Fixtures/RteConfigStringFixtureProcessing.yaml+15 −14
- typo3/sysext/rte_ckeditor/Tests/Functional/HtmlParser/HtmlParserProcessingTest.php+2 −4
Review log 1522
-
Stefan Froemken uploaded patch set 1 07/05/24, 21:51
-
Stefan Froemken commented on patch set 1 07/05/24, 21:56
-
core-ci voted on patch set 1 V -1 07/05/24, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61067
-
Stefan Froemken uploaded patch set 2
V -107/05/24, 21:58 -
Stefan Froemken uploaded patch set 3 07/05/24, 22:03
-
core-ci voted on patch set 2 V -1 07/05/24, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61068
-
core-ci voted on patch set 3 V +1 07/05/24, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61069
-
Georg Ringer voted on patch set 3 CR +1 V +1 07/09/24, 15:46
-
Benni Mack updated the commit message in patch set 4
CR +1V +110/18/24, 13:37 -
core-ci voted on patch set 4 V -1 10/18/24, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68006
-
Benni Mack rebased onto patch set 5
V -110/24/24, 09:12 -
core-ci voted on patch set 5 V +1 10/24/24, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68519
-
Garvin Hicking commented on patch set 5 CR +1 V +1 02/17/25, 17:08
I've added tests here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88244 which prove this patch as working, once the failing tests are enabled. I would first like to merge the tests and then this patch. Thank you!HtmlParser.php:545ReplyVerified broken, fix works. -
Benni Mack rebased onto patch set 6
CR +1V +102/28/25, 19:40 -
core-ci voted on patch set 6 V +1 02/28/25, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74921
-
Garvin Hicking uploaded patch set 7
V +102/28/25, 19:57 -
core-ci voted on patch set 7 V +1 02/28/25, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74922
-
Garvin Hicking commented on patch set 7 CR +1 V +1 02/28/25, 20:05
I have enabled the tests which would fail without this patch to prove it is working as described. However, I have removed the 12.4 backport of this patch, mostly because backporting the tests would be a bit of work, and I feel unsure that at this point of the v12 LTS life-cycle we should not introduce volatility to the TS/YAML parsing. Let me know if that's okay for everyone. -
Benni Mack voted on patch set 7 CR +1 V +1 02/28/25, 20:49
-
Benjamin Franzke commented on patch set 7 CR +1 03/04/25, 11:23
Thanks for the effort Stefan and Garvin, looks good. -
Garvin Hicking voted on patch set 7 CR +2 V +2 03/04/25, 11:29
-
Garvin Hicking merged patch set 8 03/04/25, 13:03
HtmlParser.php:545