Review main Merged

85140[TASK] Avoid class property $tca in TcaSchemaFactory

Christian Kuhn CR +2 V +2 Easy +7 −9 updated 07/06/24, 19:12

Commit message

TcaSchemaFactory can avoid more class state: TCA
is only used during building and can be hand
around instead of parking it on $this. This
avoids this rather huge array being attached
during entire runtime.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 07/06/24, 18:32

  2. core-ci voted on patch set 1 V +1 07/06/24, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61100

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 07/06/24, 18:50

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 07/06/24, 19:09

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 07/06/24, 19:12

  6. Christian Kuhn merged patch set 2 07/06/24, 19:12