Review main Merged

85141[TASK] Prepare stateless DiffUtility

Christian Kuhn CR +2 V +2 Normal +118 −50 updated 07/09/24, 08:28

Commit message

DiffUtility has the unfortunate property
`$stripTags`, making this tiny service
stateful. This service should not
`strip_tags()` on its own, consumers should,
if needed.

The patch adds a new method `diff()`, that
does not strip tags anymore and deprecates
the property and method `makeDiffDisplay()`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 812

  1. Christian Kuhn uploaded patch set 1 07/06/24, 19:53

  2. core-ci voted on patch set 1 V -1 07/06/24, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61105

  3. Christian Kuhn uploaded patch set 2 V -1 07/06/24, 20:16

  4. core-ci voted on patch set 2 V -1 07/06/24, 20:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61106

  5. Christian Kuhn uploaded patch set 3 V -1 07/06/24, 20:28

  6. core-ci voted on patch set 3 V +1 07/06/24, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61109

  7. Christian Kuhn uploaded patch set 4 V +1 07/06/24, 20:52

  8. core-ci voted on patch set 4 V +1 07/06/24, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61110

  9. Benni Mack voted on patch set 4 CR +1 V +1 07/09/24, 06:07

  10. Anja Leichsenring voted on patch set 4 CR +1 V +1 07/09/24, 06:48

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 07/09/24, 08:27

  12. Christian Kuhn merged patch set 5 07/09/24, 08:28