Review main Merged

85142[BUGFIX] Disable edit button for delete placeholder records

Jasmina Ließmann CR +2 V +2 Easy +2 −2 updated 07/06/24, 22:07

Commit message

Skip the "edit" pen icon in workspace BE module when
the record is a "delete placeholder" (marked for
deletion in workspaces). Such a record can not be
edited and leads to an error view.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Jasmina Ließmann uploaded patch set 1 07/06/24, 20:21

  2. core-ci voted on patch set 1 V +1 07/06/24, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61107

  3. Jasmina Ließmann updated the commit message in patch set 2 V +1 07/06/24, 20:26

  4. core-ci voted on patch set 2 V +1 07/06/24, 20:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61108

  5. Christian Kuhn updated the commit message in patch set 3 V +1 07/06/24, 21:58

  6. Christian Kuhn voted on patch set 3 CR +1 V +1 07/06/24, 21:58

  7. core-ci voted on patch set 3 V +1 07/06/24, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61115

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 07/06/24, 22:04

  9. Jasmina Ließmann voted on patch set 3 CR +2 V +2 07/06/24, 22:07

  10. Jasmina Ließmann merged patch set 4 07/06/24, 22:07