Review main Merged

85143[TASK] Avoid class property $relationMap in TcaSchemaFactory

Christian Kuhn CR +2 V +2 Easy +7 −8 updated 07/07/24, 08:44

Commit message

TcaSchemaFactory can avoid more class state:
RelationMap is only used during building and
can be hand around instead of parking it on
$this.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 07/06/24, 22:05

  2. core-ci voted on patch set 1 V +1 07/06/24, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61116

  3. Jasmina Ließmann voted on patch set 1 CR +1 V +1 07/06/24, 22:12

  4. Oliver Klee voted on patch set 1 CR +1 V +1 07/07/24, 07:48

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 07/07/24, 08:44

  6. Oli Bartsch merged patch set 2 07/07/24, 08:44