Review main Merged

85145[BUGFIX] styleguide: Have proper l10n_source field generator

Christian Kuhn CR +2 V +2 Normal +46 −5 updated 07/07/24, 09:35

Commit message

With TCA changes from #104311, l10n_source in styleguide
is now configured as type=passthrough just like everywhere
else. This needs a bit attention in styleguide data generator
to create "int'ish" values, or postgres stumbles during
insert.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 46

  1. Christian Kuhn uploaded patch set 1 07/07/24, 09:15

  2. core-ci voted on patch set 1 V +1 07/07/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61133

  3. Christian Kuhn commented on patch set 1 07/07/24, 09:25

  4. core-ci commented on patch set 1 07/07/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61134

  5. Christian Kuhn commented on patch set 1 CR +2 V +2 07/07/24, 09:34

    i'll take the freedom and get this merged without further votes to get nightly green again.
  6. Christian Kuhn merged patch set 2 07/07/24, 09:35