Review main Merged

85146[TASK] Use DI in styleguide field generators

Christian Kuhn CR +2 V +2 Expert +428 −834 updated 07/09/24, 16:27

Commit message

* Inject service dependencies
* Clean up doc headers
* generate() can return string|int over string only
  to create better typed DB values up front
* Various further minor type improvements
* readonly classes where possible

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Mogens Fiebrandt +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 68

Show 48 more files

Review log 1518

  1. Christian Kuhn uploaded patch set 1 07/07/24, 11:49

  2. core-ci voted on patch set 1 V +1 07/07/24, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61137

  3. Mogens Fiebrandt commented on patch set 1 07/07/24, 13:58

    AbstractFieldGenerator.php:45

    Wouldn't it be consistent also to remove the params annotations here.

    FieldGeneratorInterface.php:30

    Wouldn't it be consistent also to remove the params annotations here.

    FieldGeneratorResolver.php:151

    Wouldn't it be consistent also to remove the params annotations here.

    RecordData.php:36

    Wouldn't it be consistent also to remove the params annotations here.

    RecordFinder.php:258

    Wouldn't it be consistent also to remove the params annotations here.

    RecordFinder.php:311

    Wouldn't it be consistent also to remove the params annotations here.
  4. Christian Kuhn commented on patch set 1 07/09/24, 08:35

    AbstractFieldGenerator.php:45 Reply

    This comment gives additional info: more than just the type and var-name. The general idea is: Keep such annotations when they add some value, which they do in this case.

    FieldGeneratorInterface.php:30 Reply

    Done

    FieldGeneratorResolver.php:151 Reply

    Done

    RecordData.php:36 Reply

    Done

    RecordFinder.php:258 Reply

    Done

    RecordFinder.php:311 Reply

    Done
  5. Christian Kuhn uploaded patch set 2 V +1 07/09/24, 08:41

  6. core-ci voted on patch set 2 V +1 07/09/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61218

  7. Mogens Fiebrandt voted on patch set 2 CR +1 07/09/24, 10:19

  8. Anja Leichsenring voted on patch set 2 CR +1 V +1 07/09/24, 11:12

  9. Stefan Bürk voted on patch set 2 CR +1 V +1 07/09/24, 15:52

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 07/09/24, 15:58

  11. Christian Kuhn updated the commit message in patch set 3 CR +1 V +1 07/09/24, 15:58

  12. Stefan Bürk voted on patch set 3 CR +1 V +1 07/09/24, 16:00

  13. Mogens Fiebrandt voted on patch set 3 CR +1 07/09/24, 16:00

  14. core-ci voted on patch set 3 V +1 07/09/24, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61251

  15. Oli Bartsch voted on patch set 3 CR +1 V +1 07/09/24, 16:13

  16. Anja Leichsenring voted on patch set 3 CR +1 V +1 07/09/24, 16:15

  17. Christian Kuhn voted on patch set 3 CR +2 V +2 07/09/24, 16:27

  18. Christian Kuhn merged patch set 4 07/09/24, 16:27