85146[TASK] Use DI in styleguide field generators
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Anja Leichsenring +1
- Stefan Bürk +1
- Mogens Fiebrandt +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 68
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/AbstractFieldGenerator.php2+1 −21
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/ConfigDefault.php+2 −7
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeCheck.php+3 −12
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeColor.php+6 −12
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetime.php+8 −14
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeDbTypeDatetime.php+6 −12
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatDate.php+8 −14
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatDateDbTypeDate.php+6 −12
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatTime.php+9 −19
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatTimesec.php+9 −19
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeRequiredFormatDate.php+8 −14
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeEmail.php+7 −11
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeFile.php+8 −15
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeFlex.php+14 −25
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeFolder.php+6 −14
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupAllowedBeUsers.php+6 −14
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupAllowedBeUsersBeGroups.php+7 −15
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupAllowedPages.php+6 −14
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupAllowedStaticdata.php+7 −15
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupAllowedSysFiles.php+9 −24
Show 48 more files
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeGroupFal.php+8 −15
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeImageManipulation.php+2 −11
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInline1n.php+12 −19
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineExpandsingle.php+12 −17
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineFalSelectSingle12Foreign.php+12 −20
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineUsecombination.php+14 −19
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineUsecombinationGroup.php+14 −19
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInput.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputDynamicTextWithRecordUid.php+7 −11
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalAlphanum.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalIsIn.php+1 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalMd5.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalNum.php+8 −12
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalUpper.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputEvalYear.php+3 −12
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputForceL10nParent.php+2 −8
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputMax4.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputMax4Min4.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInputWizardSelect.php+1 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeLink.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeNone.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeNoneFormatDateTime.php+8 −12
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeNumber.php+8 −14
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeNumberFormatDecimal.php+7 −12
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypePassthrough.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypePassthroughFieldL10nSource.php+3 −4
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypePassword.php+10 −12
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypePasswordHashedFalse.php+6 −9
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeRadio.php+1 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelect.php+1 −11
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectRenderTypeSelectTree.php+3 −3
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectRenderTypeSingleForeignTable.php+13 −18
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectRenderTypeSingleForeignTableForType.php+8 −15
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectRenderTypeSingleForeignTableGroupField.php+15 −16
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeSelectStaticData.php+4 −4
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeText.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextDefaultExtrasRichtext.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextFormatCodeEditor.php+7 −11
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextFormatDatetime.php+8 −12
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextMax30.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextWizardSelect.php+1 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeTextWizardTable.php+1 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeUser.php+6 −10
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeUuid.php+6 −7
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGeneratorInterface.php2+1 −5
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGeneratorResolver.php2+1 −4
- typo3/sysext/styleguide/Classes/TcaDataGenerator/RecordData.php2+6 −6
- typo3/sysext/styleguide/Classes/TcaDataGenerator/RecordFinder.php4+0 −13
Review log 1518
-
Christian Kuhn uploaded patch set 1 07/07/24, 11:49
-
core-ci voted on patch set 1 V +1 07/07/24, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61137
-
Mogens Fiebrandt commented on patch set 1 07/07/24, 13:58
FieldGeneratorInterface.php:30Wouldn't it be consistent also to remove the params annotations here.FieldGeneratorResolver.php:151Wouldn't it be consistent also to remove the params annotations here.RecordData.php:36Wouldn't it be consistent also to remove the params annotations here.RecordFinder.php:258Wouldn't it be consistent also to remove the params annotations here.RecordFinder.php:311Wouldn't it be consistent also to remove the params annotations here. -
Christian Kuhn commented on patch set 1 07/09/24, 08:35
AbstractFieldGenerator.php:45ReplyThis comment gives additional info: more than just the type and var-name. The general idea is: Keep such annotations when they add some value, which they do in this case.FieldGeneratorInterface.php:30ReplyDoneFieldGeneratorResolver.php:151ReplyDoneRecordData.php:36ReplyDoneRecordFinder.php:258ReplyDoneRecordFinder.php:311ReplyDone -
Christian Kuhn uploaded patch set 2
V +107/09/24, 08:41 -
core-ci voted on patch set 2 V +1 07/09/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61218
-
Mogens Fiebrandt voted on patch set 2 CR +1 07/09/24, 10:19
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 07/09/24, 11:12
-
Stefan Bürk voted on patch set 2 CR +1 V +1 07/09/24, 15:52
-
Christian Kuhn voted on patch set 2 CR +2 V +2 07/09/24, 15:58
-
Christian Kuhn updated the commit message in patch set 3
CR +1V +107/09/24, 15:58 -
Stefan Bürk voted on patch set 3 CR +1 V +1 07/09/24, 16:00
-
Mogens Fiebrandt voted on patch set 3 CR +1 07/09/24, 16:00
-
core-ci voted on patch set 3 V +1 07/09/24, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61251
-
Oli Bartsch voted on patch set 3 CR +1 V +1 07/09/24, 16:13
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 07/09/24, 16:15
-
Christian Kuhn voted on patch set 3 CR +2 V +2 07/09/24, 16:27
-
Christian Kuhn merged patch set 4 07/09/24, 16:27
AbstractFieldGenerator.php:45