Review main Merged

85147[TASK] Use TcaSchema in SchemaMigrator

Stefan Bürk CR +2 V +2 Normal +106 −64 updated 09/06/25, 01:24

Commit message

With #104311 it is ensured to have TCA in place for
fields controlled with TCA ctrl flags, which allows
using TcaSchema in SchemaMigrator to build up field
names and prioritize system column names.

Some fields still need to be hardcoded here,
as they have no representation, neither enriched by
the system nor in the TcaSchema.

In addition, TcaSchemaFactory now needs to be configured
/ autowired manually as it is needed for the Failsafe
area.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 3

Files 7

Review log 2537

Show 712 earlier messages
  1. Stefan Bürk uploaded patch set 1 07/07/24, 17:23

  2. Stefan Bürk updated the commit message in patch set 2 07/07/24, 17:28

  3. core-ci voted on patch set 1 V -1 07/07/24, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61139

  4. core-ci voted on patch set 2 V -1 07/07/24, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61140

  5. Stefan Bürk rebased onto patch set 3 V -1 08/01/24, 16:26

  6. core-ci voted on patch set 3 V -1 08/01/24, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62597

  7. Stefan Bürk updated the commit message in patch set 4 V -1 08/01/24, 16:41

  8. Stefan Bürk updated the commit message in patch set 5 08/01/24, 16:42

  9. core-ci voted on patch set 4 V -1 08/01/24, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62598

  10. core-ci voted on patch set 5 V -1 08/01/24, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62599

  11. Benni Mack marked it work in progress 01/14/25, 12:52

  12. Benni Mack uploaded patch set 6 V -1 06/06/25, 16:31

  1. Benni Mack updated the commit message in patch set 7 06/06/25, 16:32

  2. Benni Mack marked it ready for review 06/06/25, 16:40

  3. core-ci voted on patch set 6 V -1 06/06/25, 16:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80000

  4. core-ci voted on patch set 7 V -1 06/06/25, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80001

  5. Benni Mack uploaded patch set 8 V -1 06/06/25, 20:03

  6. core-ci voted on patch set 8 V -1 06/06/25, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80012

  7. Benni Mack uploaded patch set 9 V -1 06/06/25, 21:10

  8. core-ci voted on patch set 9 V +1 06/06/25, 21:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80017

  9. Benni Mack voted on patch set 9 CR +1 V +1 06/06/25, 21:20

  10. Benni Mack updated the commit message in patch set 10 CR +1 V +1 06/06/25, 21:22

  11. Benni Mack updated the commit message in patch set 11 06/06/25, 21:22

  12. Benni Mack voted on patch set 11 CR +1 V +1 06/06/25, 21:22

  13. core-ci voted on patch set 11 V +1 06/06/25, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80022

  14. core-ci voted on patch set 10 V +1 06/06/25, 21:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80021

  15. Benni Mack uploaded patch set 12 06/06/25, 22:24

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  16. core-ci voted on patch set 12 V +1 06/06/25, 22:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80025

  17. Georg Ringer voted on patch set 12 CR +1 V +1 06/07/25, 05:41

  18. Benni Mack voted on patch set 12 CR +2 V +2 06/07/25, 06:46

  19. Benni Mack merged patch set 13 06/07/25, 06:46

  20. Oli Bartsch voted on patch set 13 CR +2 V +2 06/07/25, 06:54

  21. Benjamin Franzke commented on patch set 13 06/10/25, 09:00

    Hey, with the patch @oliver.hader@typo3.org and me are getting the following error when opening the upgrade wizards modal in the install tool: ``` (1/1) #1696424993 RuntimeException Table name sys_filemounts does not exist in incoming table list ```
  22. Benjamin Franzke commented on patch set 13 06/10/25, 09:04

    ServiceProvider.php:549

    Why did we need to provide the TcaSchemaFactory via service provider here? That's only needed if we're using it in the failsafe container in install tool context, but installtool context that uses TCA should use the full symfony container via LateBootService and therefore should *not* require this service to be defined here. (Maybe that's also the reason why we see missing tables – see my other comment – because we're using TcaSchema without a fully booted symfony container?)
  23. Benjamin Franzke wrote 06/10/25, 09:19

    Created a revert of this change as Ifd774011855b3dc801d79cb712817a7b21885764
  24. Benjamin Franzke commented on patch set 13 06/10/25, 13:25

    Reupload with my remarks and the discovered issues adressed is here: > 89688: [TASK] Use TcaSchema in SchemaMigrator | https://review.typo3.org/c/Packages/TYPO3.CMS/+/89688 I reuploaded this state as patchset 1, so you can inspect the diff between this patch via: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89688/1..3
  25. Stefan Bürk commented on patch set 13 09/06/25, 01:24

    ServiceProvider.php:549 Reply

    Done