Review main Merged

85148[TASK] Add "overrideChildTCA" cases to EXT:styleguide

Garvin Hicking CR +2 V +2 Normal +168 −1 updated 08/09/24, 16:06

Commit message

EXT:styleguide did not contain a showcase for a overrideChildTCA
configuration using both columnOverrides or columns to turn
for example a "plaintext" input element to "RTE".

This case is helpful to also reproduce problems with
FormEngine/DataHandler, where possible RTE transformations on
save might not be calculated when used as an override.

The new distinct "Form engine - inline with child overrideChildTca"
type has been added, and "Form engine - file" has a new
field "file_6" to showcase an RTE within a type=file inline
reference.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Garvin Hicking uploaded patch set 1 07/08/24, 08:39

  2. core-ci voted on patch set 1 V +1 07/08/24, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61166

  3. Garvin Hicking uploaded patch set 2 V +1 07/08/24, 09:24

  4. core-ci voted on patch set 2 V +1 07/08/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61171

  5. Garvin Hicking rebased onto patch set 3 V +1 07/31/24, 08:07

  6. core-ci voted on patch set 3 V +1 07/31/24, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62501

  7. Georg Ringer voted on patch set 3 CR +1 V +1 07/31/24, 16:05

  8. Benni Mack voted on patch set 3 CR +2 V +2 08/09/24, 16:05

  9. Benni Mack merged patch set 4 08/09/24, 16:06