Review main Merged

85149[BUGFIX] Fix generation of arbitrary HMENU with userfunction

Xavier Perseguers CR +2 V +2 Easy +11 −7 updated 10/28/24, 20:42

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1216

  1. Xavier Perseguers uploaded patch set 1 07/08/24, 13:22

  2. core-ci voted on patch set 1 V +1 07/08/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61173

  3. Fabien Udriot voted on patch set 1 CR +1 07/09/24, 09:32

  4. Benni Mack updated the commit message in patch set 2 CR +1 V +1 10/18/24, 13:37

  5. core-ci voted on patch set 2 V -1 10/18/24, 22:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68005

  6. Benni Mack rebased onto patch set 3 V -1 10/28/24, 12:31

  7. core-ci voted on patch set 3 V +1 10/28/24, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68725

  8. Benni Mack voted on patch set 3 CR +1 V +1 10/28/24, 13:25

  9. Markus Klein commented on patch set 3 CR +1 10/28/24, 14:15

    The ticket is for v12. Any reason this is not fixed for v12 as well?
  10. Benni Mack updated the commit message in patch set 4 CR +1 V +1 10/28/24, 15:16

  11. Benni Mack commented on patch set 4 CR +1 10/28/24, 15:16

    Reply

    no particular reason, if you find somebody else who is willing to test this change other than me... :)
  12. core-ci voted on patch set 4 V +1 10/28/24, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68729

  13. Markus Klein commented on patch set 4 CR +1 V +1 10/28/24, 17:42

    I did indeed test this on my local v12 coredev instance.
  14. Benni Mack voted on patch set 4 CR +2 V +2 10/28/24, 20:41

  15. Benni Mack merged patch set 5 10/28/24, 20:41

  16. Benni Mack commented on patch set 5 10/28/24, 20:42

    Thank you markus!