Review main Merged

85150[TASK] Make buttons context aware

Benjamin Kott CR +2 V +2 Hard +396 −307 updated 07/10/24, 11:30

Commit message

We are dropping the Bootstrap CSS definitions for
buttons to have more control about the styling of
the buttons. From now on we are shipping custom
css adapted to our needs. The new button styling
is context aware and adapts to light and dark
color schemes.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 1525

  1. Benjamin Kott uploaded patch set 1 07/08/24, 13:40

  2. core-ci voted on patch set 1 V -1 07/08/24, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61174

  3. Benjamin Kott uploaded patch set 2 V -1 07/09/24, 13:05

  4. core-ci voted on patch set 2 V -1 07/09/24, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61235

  5. Benjamin Kott uploaded patch set 3 V -1 07/09/24, 14:06

  6. core-ci voted on patch set 3 V -1 07/09/24, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61242

  7. Benjamin Kott uploaded patch set 4 V -1 07/09/24, 14:21

  8. core-ci voted on patch set 4 V +1 07/09/24, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61243

  9. Benjamin Kott uploaded patch set 5 V +1 07/10/24, 08:32

  10. core-ci voted on patch set 5 V -1 07/10/24, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61296

  11. Benjamin Kott uploaded patch set 6 V -1 07/10/24, 09:29

  12. core-ci voted on patch set 6 V -1 07/10/24, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61302

  13. Benjamin Kott uploaded patch set 7 V -1 07/10/24, 10:18

  14. core-ci voted on patch set 7 V +1 07/10/24, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61305

  15. Benjamin Kott updated the commit message in patch set 8 V +1 07/10/24, 10:41

  16. core-ci voted on patch set 8 V -1 07/10/24, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61307

  17. Benjamin Kott uploaded patch set 9 V -1 07/10/24, 10:52

  18. core-ci voted on patch set 9 V +1 07/10/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61309

  19. Benjamin Kott uploaded patch set 10 V +1 07/10/24, 10:58

  20. Fabien Udriot voted on patch set 9 CR +1 07/10/24, 10:59

  21. core-ci voted on patch set 10 V +1 07/10/24, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61310

  22. Benjamin Franzke commented on patch set 10 CR +1 V +1 07/10/24, 11:25

    _root.scss:88

    I'd prefer neutral-75 for dark-mode btn-default border, but we can fine-tune that later on. ;)

    AuthenticationStyleInformation.php:81

    computed values should use a base-color property. Can be changed in a subsequent commit
  23. Andreas Kienast voted on patch set 10 CR +1 V +1 07/10/24, 11:29

  24. Benjamin Kott voted on patch set 10 CR +2 V +2 07/10/24, 11:30

  25. Benjamin Kott merged patch set 11 07/10/24, 11:30