Review main Merged

85152[BUGFIX] Fix event binding in scheduler task form docheader

Andreas Kienast CR +2 V +2 Easy +9 −9 updated 07/09/24, 06:19

Commit message

This commit fixes the event binding on the "Close" and "Save" actions to
trigger the correct actions when e.g. the icons within the buttons are
clicked.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Andreas Kienast uploaded patch set 1 07/08/24, 15:15

  2. core-ci voted on patch set 1 V -1 07/08/24, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61179

  3. core-ci voted on patch set 1 V +1 07/08/24, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61179

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 07/08/24, 18:05

    I tried many possible combination (save with changes, save without changes, close: discard, continue, save with changes, close: discard, continue, save without changes), worked in all cases. Firefox and Chromium, OSX.
  5. Georg Ringer voted on patch set 1 CR +1 V +1 07/08/24, 19:21

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 07/09/24, 06:19

  7. Andreas Kienast merged patch set 2 07/09/24, 06:19