Review main Merged

85186[TASK] Add submodules to "Styleguide" backend module

Jasmina Ließmann CR +2 V +2 Expert +1414 −798 updated 07/11/24, 12:14

Commit message

Over time, EXT:stylguide has expanded its range of functions.
To clarify the separation between styles and components, as well
as the functionality of creating example page trees, the contents
of the backend module "Styleguide" are divided into submodules.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 33

Show 13 more files

Review log 2748

Show 1323 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 07/09/24, 15:59

  2. core-ci voted on patch set 1 V -1 07/09/24, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61252

  3. Jasmina Ließmann uploaded patch set 2 V -1 07/10/24, 13:29

  4. Jasmina Ließmann uploaded patch set 3 07/10/24, 13:30

  5. core-ci voted on patch set 2 V -1 07/10/24, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61318

  6. core-ci voted on patch set 3 V -1 07/10/24, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61319

  7. Jasmina Ließmann uploaded patch set 4 V -1 07/11/24, 06:53

  8. core-ci voted on patch set 4 V +1 07/11/24, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61350

  9. Jasmina Ließmann uploaded patch set 5 V +1 07/11/24, 07:00

  10. core-ci voted on patch set 5 V +1 07/11/24, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61352

  11. Jasmina Ließmann uploaded patch set 6 V +1 07/11/24, 07:21

  12. Jasmina Ließmann uploaded patch set 7 07/11/24, 07:22

  13. core-ci voted on patch set 6 V -1 07/11/24, 07:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61353

  14. core-ci voted on patch set 7 V -1 07/11/24, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61354

  15. Jasmina Ließmann uploaded patch set 8 V -1 07/11/24, 08:01

  16. core-ci voted on patch set 8 V +1 07/11/24, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61355

  17. Jasmina Ließmann uploaded patch set 9 V +1 07/11/24, 09:20

  18. core-ci voted on patch set 9 V +1 07/11/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61360

  19. Jasmina Ließmann uploaded patch set 10 07/11/24, 09:26

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  20. core-ci voted on patch set 10 V +1 07/11/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61361

  21. Jasmina Ließmann uploaded patch set 11 V +1 07/11/24, 09:40

  22. Jasmina Ließmann uploaded patch set 12 07/11/24, 09:41

  23. Jasmina Ließmann uploaded patch set 13 07/11/24, 09:43

  1. core-ci voted on patch set 11 V +1 07/11/24, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61362

  2. core-ci voted on patch set 12 V +1 07/11/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61363

  3. core-ci voted on patch set 13 V +1 07/11/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61364

  4. Jasmina Ließmann updated the commit message in patch set 14 V +1 07/11/24, 09:51

  5. Jasmina Ließmann updated the commit message in patch set 15 07/11/24, 09:52

  6. core-ci voted on patch set 14 V +1 07/11/24, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61365

  7. Jasmina Ließmann updated the commit message in patch set 16 07/11/24, 09:58

  8. core-ci voted on patch set 15 V +1 07/11/24, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61366

  9. Jasmina Ließmann uploaded patch set 17 07/11/24, 10:05

  10. core-ci voted on patch set 16 V +1 07/11/24, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61367

  11. Jasmina Ließmann updated the commit message in patch set 18 07/11/24, 10:06

  12. core-ci voted on patch set 17 V +1 07/11/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61368

  13. Jasmina Ließmann uploaded patch set 19 07/11/24, 10:13

  14. core-ci voted on patch set 18 V +1 07/11/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61369

  15. core-ci voted on patch set 19 V +1 07/11/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61371

  16. Jasmina Ließmann uploaded patch set 20 V +1 07/11/24, 10:27

  17. core-ci voted on patch set 20 V +1 07/11/24, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61373

  18. Simon Schaufelberger commented on patch set 20 07/11/24, 10:56

    StylesController.php:82

    a final class can't be extended so these methods should be private
  19. Simon Schaufelberger commented on patch set 20 07/11/24, 10:58

    Modules.php:17

    you can import these class names without causing any problems.
  20. Benjamin Franzke commented on patch set 20 07/11/24, 11:57

    Separation is good and indeed needed now, thanks!

    BackendController.php:107

    I think a general overview for Components, Style and Data Generation would be useful. But that can be added later IMO. (Actually the sub-overviews are less important)

    Modules.php:36

    I'd order components before styles, as it contains the most relevant information for developers (styles is rather something for us)
  21. Benjamin Franzke uploaded patch set 21 V +1 07/11/24, 12:08

  22. Benjamin Franzke commented on patch set 21 07/11/24, 12:08

    BackendController.php:107 Reply

    as mentioned, for later.

    StylesController.php:82 Reply

    Done

    Modules.php:17 Reply

    Done

    Modules.php:36 Reply

    Done
  23. core-ci voted on patch set 21 V +1 07/11/24, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61381

  24. Benjamin Kott voted on patch set 21 CR +2 V +2 07/11/24, 12:14

  25. Benjamin Kott merged patch set 22 07/11/24, 12:14