85186[TASK] Add submodules to "Styleguide" backend module
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 33
- typo3/sysext/core/Tests/Acceptance/Application/Styleguide/NotificationCest.php+1 −1
- typo3/sysext/styleguide/Classes/Controller/BackendController.php2deleted+0 −525
- typo3/sysext/styleguide/Classes/Controller/ComponentsController.phpnew+375 −0
- typo3/sysext/styleguide/Classes/Controller/PageTreesController.phpnew+210 −0
- typo3/sysext/styleguide/Classes/Controller/StylesController.php2new+189 −0
- typo3/sysext/styleguide/Configuration/Backend/Modules.php4+48 −4
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+144 −118
- typo3/sysext/styleguide/Resources/Private/Partials/Backend/Navigation.html+2 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Accordion.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Avatar.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Badges.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Buttons.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Cards.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Filter.htmlrenamed+17 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/FlashMessages.htmlnew+27 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Infobox.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Modal.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Notifications.htmlrenamed+17 −4
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Pagination.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/ProgressIndicators.htmlrenamed+13 −3
Show 13 more files
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Tab.htmlrenamed+13 −3
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Tables.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Trees.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/ColorTokens.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/Icons.htmlrenamed+17 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/Shadows.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/Surfaces.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/Typography.htmlrenamed+9 −2
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/ComponentsOverview.htmlnew+50 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/FlashMessages.htmldeleted+0 −22
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Index.htmldeleted+0 −84
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/ManagePageTrees.htmlnew+115 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/StylesOverview.htmlnew+50 −0
Review log 2748
Show 1323 earlier messages
-
Jasmina Ließmann uploaded patch set 1 07/09/24, 15:59
-
core-ci voted on patch set 1 V -1 07/09/24, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61252
-
Jasmina Ließmann uploaded patch set 2
V -107/10/24, 13:29 -
Jasmina Ließmann uploaded patch set 3 07/10/24, 13:30
-
core-ci voted on patch set 2 V -1 07/10/24, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61318
-
core-ci voted on patch set 3 V -1 07/10/24, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61319
-
Jasmina Ließmann uploaded patch set 4
V -107/11/24, 06:53 -
core-ci voted on patch set 4 V +1 07/11/24, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61350
-
Jasmina Ließmann uploaded patch set 5
V +107/11/24, 07:00 -
core-ci voted on patch set 5 V +1 07/11/24, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61352
-
Jasmina Ließmann uploaded patch set 6
V +107/11/24, 07:21 -
Jasmina Ließmann uploaded patch set 7 07/11/24, 07:22
-
core-ci voted on patch set 6 V -1 07/11/24, 07:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61353
-
core-ci voted on patch set 7 V -1 07/11/24, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61354
-
Jasmina Ließmann uploaded patch set 8
V -107/11/24, 08:01 -
core-ci voted on patch set 8 V +1 07/11/24, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61355
-
Jasmina Ließmann uploaded patch set 9
V +107/11/24, 09:20 -
core-ci voted on patch set 9 V +1 07/11/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61360
-
Jasmina Ließmann uploaded patch set 10 07/11/24, 09:26
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 10 V +1 07/11/24, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61361
-
Jasmina Ließmann uploaded patch set 11
V +107/11/24, 09:40 -
Jasmina Ließmann uploaded patch set 12 07/11/24, 09:41
-
Jasmina Ließmann uploaded patch set 13 07/11/24, 09:43
-
core-ci voted on patch set 11 V +1 07/11/24, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61362
-
core-ci voted on patch set 12 V +1 07/11/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61363
-
core-ci voted on patch set 13 V +1 07/11/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61364
-
Jasmina Ließmann updated the commit message in patch set 14
V +107/11/24, 09:51 -
Jasmina Ließmann updated the commit message in patch set 15 07/11/24, 09:52
-
core-ci voted on patch set 14 V +1 07/11/24, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61365
-
Jasmina Ließmann updated the commit message in patch set 16 07/11/24, 09:58
-
core-ci voted on patch set 15 V +1 07/11/24, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61366
-
Jasmina Ließmann uploaded patch set 17 07/11/24, 10:05
-
core-ci voted on patch set 16 V +1 07/11/24, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61367
-
Jasmina Ließmann updated the commit message in patch set 18 07/11/24, 10:06
-
core-ci voted on patch set 17 V +1 07/11/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61368
-
Jasmina Ließmann uploaded patch set 19 07/11/24, 10:13
-
core-ci voted on patch set 18 V +1 07/11/24, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61369
-
core-ci voted on patch set 19 V +1 07/11/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61371
-
Jasmina Ließmann uploaded patch set 20
V +107/11/24, 10:27 -
core-ci voted on patch set 20 V +1 07/11/24, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61373
-
Simon Schaufelberger commented on patch set 20 07/11/24, 10:56
StylesController.php:82a final class can't be extended so these methods should be private -
Simon Schaufelberger commented on patch set 20 07/11/24, 10:58
Modules.php:17you can import these class names without causing any problems. -
Benjamin Franzke commented on patch set 20 07/11/24, 11:57
Separation is good and indeed needed now, thanks!BackendController.php:107I think a general overview for Components, Style and Data Generation would be useful. But that can be added later IMO. (Actually the sub-overviews are less important)Modules.php:36I'd order components before styles, as it contains the most relevant information for developers (styles is rather something for us) -
Benjamin Franzke uploaded patch set 21
V +107/11/24, 12:08 -
Benjamin Franzke commented on patch set 21 07/11/24, 12:08
BackendController.php:107Replyas mentioned, for later.StylesController.php:82ReplyDoneModules.php:17ReplyDoneModules.php:36ReplyDone -
core-ci voted on patch set 21 V +1 07/11/24, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61381
-
Benjamin Kott voted on patch set 21 CR +2 V +2 07/11/24, 12:14
-
Benjamin Kott merged patch set 22 07/11/24, 12:14