85187[TASK] Allow floats for TCA type number range values
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2534
Show 69 earlier messages
-
Georg Ringer uploaded patch set 1 07/09/24, 16:09
-
Georg Ringer commented on patch set 1 07/09/24, 16:09
This change is ready for review. -
core-ci voted on patch set 1 V -1 07/09/24, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61253
-
Georg Ringer uploaded patch set 2
V -107/09/24, 20:43 -
core-ci voted on patch set 2 V -1 07/09/24, 20:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61259
-
Georg Ringer uploaded patch set 3
V -107/09/24, 21:18 -
core-ci voted on patch set 3 V +1 07/09/24, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61261
-
Christian Kuhn commented on patch set 3 07/11/24, 12:28
tx_styleguide_elements_basic.php:775this is identical with number_4 -
Georg Ringer uploaded patch set 4
V +107/11/24, 16:01
-
core-ci voted on patch set 4 V +1 07/11/24, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61397
-
Christian Kuhn commented on patch set 4 CR -1 07/11/24, 18:03
tx_styleguide_elements_basic.php:1868number_6 still in here. -
Christian Kuhn uploaded patch set 5
CR -1V +107/11/24, 18:04 -
Christian Kuhn commented on patch set 4 CR -1 07/11/24, 18:04
tx_styleguide_elements_basic.php:775ReplyDonetx_styleguide_elements_basic.php:1868ReplyDone -
Christian Kuhn voted on patch set 5 CR +1 V +1 07/11/24, 18:05
-
core-ci voted on patch set 5 V +1 07/11/24, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61404
-
Benni Mack updated the commit message in patch set 6
CR +1V +110/18/24, 13:37 -
core-ci voted on patch set 6 V -1 10/18/24, 22:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68008
-
Georg Ringer uploaded patch set 7
V -112/11/24, 20:56 -
core-ci voted on patch set 7 V +1 12/11/24, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70986
-
Christian Kuhn voted on patch set 7 CR +1 V +1 12/12/24, 11:38
-
Nikita Hovratov voted on patch set 7 CR +1 12/12/24, 15:02
-
Garvin Hicking commented on patch set 7 12/12/24, 22:58
NumberElement.php:191Shouldn't float only be casted with format=decimal here? -
Christian Kuhn commented on patch set 7 12/17/24, 14:24
NumberElement.php:191Replyas far as i understand, it does not matter much in this case. are you able to create an actual issue with not having this in a dedicated 'if'? -
Garvin Hicking commented on patch set 7 12/17/24, 15:59
NumberElement.php:191ReplyUnsure, and probably won't find time to dive into this. I'm resolving this when you're feeling good with this, not blocking. -
Georg Ringer rebased onto patch set 8
CR +1V +101/20/25, 19:21 -
core-ci voted on patch set 8 V +1 01/20/25, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72742
-
Georg Ringer rebased onto patch set 9
V +102/03/25, 19:49 -
core-ci voted on patch set 9 V +1 02/03/25, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73441
-
Nikita Hovratov wrote 02/05/25, 09:03
Removed reviewer Nikita Hovratov. -
Christian Kuhn voted on patch set 9 CR +1 V +1 02/05/25, 09:24
-
Benni Mack voted on patch set 9 CR +1 V +1 02/05/25, 09:49
-
Garvin Hicking voted on patch set 9 CR +1 V +1 02/05/25, 10:16
-
Benni Mack voted on patch set 9 CR +2 V +2 02/05/25, 15:33
-
Benni Mack merged patch set 10 02/05/25, 15:33