Review main Merged

85189[BUGFIX] Prevent multiple FlexContainers of same name

Georg Ringer CR +2 V +2 Normal +50 −3 updated 07/11/24, 19:43

Commit message

Extend the identifier used within the DOM by an additional field, as
already done in #97042 to make flexform sections within inline child
records work.

A styleguide example makes it easy to reproduce the edge case.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 912

  1. Georg Ringer uploaded patch set 1 07/09/24, 20:34

  2. Georg Ringer commented on patch set 1 07/09/24, 20:34

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 07/09/24, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61257

  4. Christian Kuhn updated the commit message in patch set 2 V +1 07/09/24, 21:43

  5. core-ci voted on patch set 2 V +1 07/09/24, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61262

  6. Garvin Hicking uploaded patch set 3 V +1 07/10/24, 12:17

    Add another more complex inline example with tabs
  7. Garvin Hicking commented on patch set 3 CR +1 V +1 07/10/24, 12:18

    Works for me; I've also added the other flexsection+tabbed flexform XML to achieve maximum complexity and that works too.
  8. core-ci voted on patch set 3 V +1 07/10/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61312

  9. Oli Bartsch commented on patch set 3 CR +1 V +1 07/10/24, 12:55

    Nice catch!
  10. Christian Kuhn voted on patch set 3 CR +1 V +1 07/11/24, 18:40

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 07/11/24, 19:43

  12. Christian Kuhn merged patch set 4 07/11/24, 19:43