Review main Merged

85190[BUGFIX] Prevent TypeError int values of backend user settings

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 07/10/24, 08:04

Commit message

PHP will cast array keys to int if they are valid integers.
The code applies htmlspecialchars() on the keys.
The function expects a string as first argument, which wouldn't be the
case if the actual value would be an int.

Therefore the key is casted to a string within the function call to
prevent TypeError.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Daniel Siepmann uploaded patch set 1 07/10/24, 05:53

  2. core-ci voted on patch set 1 V +1 07/10/24, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61285

  3. Georg Ringer voted on patch set 1 CR +1 V +1 07/10/24, 07:05

  4. Oli Bartsch voted on patch set 1 CR +2 V +2 07/10/24, 08:04

  5. Oli Bartsch merged patch set 2 07/10/24, 08:04