Review main Merged

85212[BUGFIX] Fix composer PackageArtifact packagePath resolve for root pkgs

Garvin Hicking CR +2 V +2 Easy +5 −1 updated 07/12/24, 16:31

Commit message

With #103898 the handling of `handleRootPackage()` was streamlined.

This lead to root packages' paths not being set to the base dir
of the composer installation any more.

The missing code is now added again.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Nikita Hovratov +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Nikita Hovratov +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 812

  1. Garvin Hicking uploaded patch set 1 07/10/24, 08:04

  2. Garvin Hicking uploaded patch set 2 07/10/24, 08:05

  3. core-ci voted on patch set 1 V -1 07/10/24, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61294

  4. core-ci voted on patch set 2 V +1 07/10/24, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61295

  5. Elias Häußler voted on patch set 2 CR +1 V +1 07/10/24, 08:24

  6. core-ci commented on patch set 2 07/10/24, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61297

  7. Helmut Hummel uploaded patch set 3 CR +1 V +1 07/10/24, 09:31

  8. Elias Häußler voted on patch set 3 CR +1 V +1 07/10/24, 09:34

  9. core-ci voted on patch set 3 V +1 07/10/24, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61303

  10. Helmut Hummel voted on patch set 3 CR +2 V +2 07/10/24, 11:23

  11. Nikita Hovratov voted on patch set 3 CR +1 V +1 07/11/24, 15:43

  12. Helmut Hummel merged patch set 4 07/12/24, 16:31