Review main Merged

85213[BUGFIX] Set `hidden` on toggling alert visibility state

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 07/10/24, 09:47

Commit message

Toggling the visibility of the new alert element,
introduced with #103699, does actually lead to
changing the `opacity` property. Therefore, the
corresponding space of the alert element will
stay, leaving empty spaces in the backend.

This is now resolved by additionally toggling the
`hidden` class, which works with the `display`
property.

Note: The `show` class has to stay due to the
underlying functionality from the used bootstrap
component.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Marcin Sągol +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Marcin Sągol +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Oli Bartsch uploaded patch set 1 07/10/24, 09:05

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 07/10/24, 09:07

  3. Oli Bartsch updated the commit message in patch set 2 CR +1 V +1 07/10/24, 09:07

  4. Andreas Kienast voted on patch set 2 CR +1 V +1 07/10/24, 09:08

  5. core-ci voted on patch set 1 V +1 07/10/24, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61300

  6. core-ci voted on patch set 2 V +1 07/10/24, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61301

  7. Marcin Sągol voted on patch set 2 CR +1 V +1 07/10/24, 09:25

  8. Oli Bartsch voted on patch set 2 CR +2 V +2 07/10/24, 09:47

  9. Oli Bartsch merged patch set 3 07/10/24, 09:47