Review main Merged

85214[TASK] Remove unused inline settings from workspace preview

Andreas Kienast CR +2 V +2 Easy +0 −8 updated 08/13/24, 11:17

Commit message

The `PreviewController` of EXT:workspaces registers some inline settings
for use in JavaScript that are actually not used at all and are
therefore removed now.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1115

  1. Andreas Kienast uploaded patch set 1 07/10/24, 11:25

  2. core-ci voted on patch set 1 V +1 07/10/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61311

  3. Benni Mack commented on patch set 1 07/10/24, 12:07

    PreviewController.php:77

    this is still needed IMHO
  4. Andreas Kienast commented on patch set 1 07/10/24, 12:21

    PreviewController.php:77 Reply

    I didn't find any usage, but feel free to enlighten me :)
  5. Benni Mack commented on patch set 1 CR +1 V +1 07/11/24, 12:10

    PreviewController.php:77 Reply

    At least currently, one "could" open (see Preview/Index.html) a FormEngine out of the Preview-mode.
  6. Christian Kuhn voted on patch set 1 CR +1 V +1 08/13/24, 11:00

  7. Christian Kuhn updated the commit message in patch set 2 CR +1 V +1 08/13/24, 11:01

  8. Christian Kuhn rebased onto patch set 3 08/13/24, 11:01

  9. Christian Kuhn voted on patch set 3 CR +1 V +1 08/13/24, 11:01

  10. Christian Kuhn commented on patch set 3 08/13/24, 11:02

    removed v12. imho: merge when green, bennis vote still applies (no code change).
  11. core-ci voted on patch set 2 V +1 08/13/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63300

  12. core-ci voted on patch set 3 V -1 08/13/24, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63301

  13. core-ci voted on patch set 3 V +1 08/13/24, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63301

  14. Andreas Kienast voted on patch set 3 CR +2 V +2 08/13/24, 11:17

  15. Andreas Kienast merged patch set 4 08/13/24, 11:17