Review main Merged

85216[TASK] Modernize `TypoScriptReferenceController`

Andreas Kienast CR +2 V +2 Easy +6 −22 updated 07/11/24, 07:42

Commit message

The class `TypoScriptReferenceController` used by our code editor get
some minor updates:

* Removed unneded `$xmlDoc` property
* Added missing type declarations
* Resolved open @todo

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Andreas Kienast uploaded patch set 1 07/10/24, 13:14

  2. core-ci voted on patch set 1 V +1 07/10/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61316

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 07/10/24, 13:26

  4. Oli Bartsch commented on patch set 1 07/10/24, 13:30

    TypoScriptReferenceController.php:44

    Can we get rid of this method and include it in the loadReference() directly?
  5. Simon Schaufelberger commented on patch set 1 CR +1 V +1 07/10/24, 13:30

    no brainer
  6. Andreas Kienast uploaded patch set 2 CR +1 V +1 07/10/24, 13:57

  7. Andreas Kienast commented on patch set 2 07/10/24, 13:57

    TypoScriptReferenceController.php:44 Reply

    Done
  8. Simon Schaufelberger voted on patch set 2 CR +1 V +1 07/10/24, 13:59

  9. core-ci voted on patch set 2 V +1 07/10/24, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61320

  10. Oli Bartsch voted on patch set 2 CR +1 V +1 07/10/24, 14:26

  11. Andreas Kienast voted on patch set 2 CR +2 V +2 07/10/24, 14:36

  12. Andreas Kienast merged patch set 3 07/10/24, 14:36

  13. Oliver Hader voted on patch set 3 CR +1 07/11/24, 07:42