Review main Merged

85218[TASK] Use custom element for indexed search statistics

Oli Bartsch CR +2 V +2 Normal +120 −103 updated 07/18/24, 09:44

Commit message

This also removed a duplicated check for the element's type.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1317

  1. Oli Bartsch uploaded patch set 1 07/10/24, 14:33

  2. core-ci voted on patch set 1 V +1 07/10/24, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61324

  3. Oli Bartsch uploaded patch set 2 V +1 07/10/24, 14:52

  4. Andreas Kienast commented on patch set 2 07/10/24, 14:54

    @ben@bnf.dev can you please cross-check whether this is fine and race-condition free?
  5. core-ci voted on patch set 2 V +1 07/10/24, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61327

  6. Benjamin Franzke commented on patch set 2 CR -1 07/12/24, 07:01

    Reply

    Thanks for the HEADS UP! This is indeed racy as it is not guaranteed that the `table` element is available by the time the custom element constructor is invoked. This is very similar to https://forge.typo3.org/issues/102550 A solution would be to use the `slotchange`-event approach from https://review.typo3.org/c/Packages/TYPO3.CMS/+/81993
  7. Oli Bartsch uploaded patch set 3 CR -1 V +1 07/12/24, 07:29

  8. Oli Bartsch commented on patch set 3 07/12/24, 07:29

    Reply

    Done
  9. Andreas Kienast commented on patch set 3 07/12/24, 07:33

    statistics.ts:43

    Shouldn't this be `wordList === null ||`?
  10. core-ci voted on patch set 3 V +1 07/12/24, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61457

  11. Oli Bartsch uploaded patch set 4 V +1 07/12/24, 08:35

  12. Oli Bartsch commented on patch set 4 07/12/24, 08:35

    statistics.ts:43 Reply

    Done
  13. core-ci voted on patch set 4 V +1 07/12/24, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61465

  14. Andreas Kienast voted on patch set 4 CR +1 V +1 07/17/24, 08:31

  15. Jochen Roth voted on patch set 4 CR +1 V +1 07/18/24, 09:40

  16. Oli Bartsch voted on patch set 4 CR +2 V +2 07/18/24, 09:44

  17. Oli Bartsch merged patch set 5 07/18/24, 09:44