Review main Merged

85221[BUGFIX] Do not use getIconHtml() for other language thumbnail

Oli Bartsch CR +2 V +2 Easy +19 −15 updated 07/12/24, 06:59

Commit message

The `OtherLanguageThumbnails` field wizard renders
thumbnails of each crop variant from the default
language for images in translations. However,
on the first view, the cropped (processed) image
is not created yet, leading to the public url
being an absolute url to the `image_processing`
route, e.g. "https://example.com/typo3/image/process?token=abc&id=123".

This URL can not be used by `getIconHtml()` to
create the markup. However the function call
is not needed at all, since we can just render
the markup directly as no icon is about to be
generated.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 07/10/24, 22:07

  2. core-ci voted on patch set 1 V +1 07/10/24, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61331

  3. Simon Schaufelberger updated the commit message in patch set 2 V +1 07/10/24, 22:35

  4. core-ci voted on patch set 2 V +1 07/10/24, 22:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61332

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 07/11/24, 13:32

    Great, also good catch by Riccardo! :)
  6. Christian Kuhn voted on patch set 2 CR +1 V +1 07/11/24, 22:19

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 07/12/24, 06:40

  8. Oli Bartsch merged patch set 3 07/12/24, 06:59