Review main Merged

85223[TASK] Make text colors context aware

Benjamin Kott CR +2 V +2 Normal +126 −59 updated 07/11/24, 12:46

Commit message

We replace the default bootstrap `text-<color>`
utility CSS classes with an own color-scheme
aware implementation.

In contrast to the original bootstrap color
utilities we ensure that the new set is
accessible and optimize the color contrast
for all values. This results in darker colors for
light-mode and lighter colors for dark-mode.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 813

  1. Benjamin Kott uploaded patch set 1 07/11/24, 11:44

  2. Georg Ringer updated the commit message in patch set 2 07/11/24, 11:45

  3. core-ci voted on patch set 1 V +1 07/11/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61377

  4. core-ci voted on patch set 2 V +1 07/11/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61378

  5. Benjamin Kott uploaded patch set 3 V +1 07/11/24, 12:16

  6. core-ci voted on patch set 3 V +1 07/11/24, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61383

  7. Benjamin Franzke uploaded patch set 4 V +1 07/11/24, 12:32

  8. Benjamin Franzke uploaded patch set 5 CR +1 V +1 07/11/24, 12:38

  9. core-ci voted on patch set 4 V +1 07/11/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61384

  10. Andreas Kienast voted on patch set 5 CR +1 V +1 07/11/24, 12:43

  11. core-ci voted on patch set 5 V +1 07/11/24, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61385

  12. Benjamin Kott voted on patch set 5 CR +2 V +2 07/11/24, 12:46

  13. Benjamin Kott merged patch set 6 07/11/24, 12:46