85229[TASK] Ensure TcaSchema are sorted alphabetically
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 10
- typo3/sysext/core/Classes/Schema/TcaSchemaFactory.php+1 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/Modify/DataSet/copyPageWHotelBeforeParentContent.csv+26 −26
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesModify/DataSet/copyPageWHotelBeforeParentContent.csv+25 −25
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesPublish/DataSet/copyPageWHotelBeforeParentContent.csv+25 −25
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/WorkspacesPublishAll/DataSet/copyPageWHotelBeforeParentContent.csv+25 −25
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/copyPageWHotelBeforeParentContent.csv+8 −8
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/DataSet/copyPageWHotelBeforeParentContent.csv+24 −24
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublish/DataSet/copyPageWHotelBeforeParentContent.csv+24 −24
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesPublishAll/DataSet/copyPageWHotelBeforeParentContent.csv+24 −24
- typo3/sysext/core/Tests/Functional/Schema/TcaSchemaTest.php+6 −1
Review log 2739
Show 1014 earlier messages
-
Benni Mack uploaded patch set 1 07/11/24, 18:53
-
Benni Mack updated the commit message in patch set 2 07/11/24, 18:57
-
Christian Kuhn voted on patch set 2 CR +1 V +1 07/11/24, 19:01
-
Jasmina Ließmann voted on patch set 2 CR +1 V +1 07/11/24, 19:02
-
core-ci voted on patch set 1 V -1 07/11/24, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61409
-
Christian Kuhn voted on patch set 2 CR 0 V 0 07/11/24, 19:06
-
core-ci voted on patch set 2 V -1 07/11/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61410
-
Jasmina Ließmann voted on patch set 2 CR 0 V 0 07/11/24, 19:06
-
Benni Mack rebased onto patch set 3
V -107/15/24, 15:04 -
core-ci voted on patch set 3 V -1 07/15/24, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61594
-
Anja Leichsenring uploaded patch set 4
V -110/16/24, 10:20 -
core-ci voted on patch set 4 V -1 10/16/24, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67878
-
Georg Ringer voted on patch set 4 CR +1 V +1 10/16/24, 11:46
-
Anja Leichsenring commented on patch set 4 V -1 10/16/24, 11:54
on it, fixing tests
-
Anja Leichsenring uploaded patch set 5
CR +1V +110/16/24, 13:37 -
core-ci voted on patch set 5 V -1 10/16/24, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67884
-
Anja Leichsenring uploaded patch set 6
V -110/16/24, 13:44 -
core-ci voted on patch set 6 V +1 10/16/24, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67885
-
Christian Kuhn commented on patch set 6 CR -1 10/17/24, 13:52
we need to understand where and why DH acts differently when the first level TCA key is sorted alphabetically and which impact this has, before the patch can be merged. -
Anja Leichsenring uploaded patch set 7
CR -1V +111/08/24, 08:39 -
Anja Leichsenring commented on patch set 7 CR -1 11/08/24, 08:40
reapply negavite vote from https://review.typo3.org/c/Packages/TYPO3.CMS/+/85229/comments/638eace3_da15346c -
core-ci voted on patch set 7 V +1 11/08/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69223
-
Benni Mack marked it work in progress 03/21/25, 17:22
-
Anja Leichsenring rebased onto patch set 8
CR -1V +103/22/25, 13:31 -
core-ci voted on patch set 8 V -1 03/22/25, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76021
-
Benni Mack uploaded patch set 9
V -103/23/25, 09:17 -
core-ci voted on patch set 9 V +1 03/23/25, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76061
-
Benni Mack commented on patch set 9 03/24/25, 10:04
Reply
This is happening in DataHandler->getAllowedTablesToCopyWhenCopyingAPage(). For the tests. Before the order was: - tx_testirrecsv_hotel - tt_content - tx_testirrecsv_offer - tx_testirrecsv_price After the order is: - tt_content - tx_testirrecsv_hotel - tx_testirrecsv_offer - tx_testirrecsv_price -
Benni Mack uploaded patch set 10
V +101/28/26, 18:13 -
core-ci voted on patch set 10 V +1 01/28/26, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94526
-
Jasmina Ließmann wrote 02/04/26, 10:00
Removed reviewer Jasmina Ließmann. -
Benni Mack updated the commit message in patch set 11
V +102/25/26, 13:22 -
Benni Mack commented on patch set 11 02/25/26, 13:23
This change is ready for review.Reply
I now added a proper note to the commit message. -
core-ci voted on patch set 11 V -1 02/25/26, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96822
-
Benni Mack rebased onto patch set 12
V -102/25/26, 16:45 -
core-ci voted on patch set 12 V +1 02/25/26, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96840
-
Simon Schaufelberger voted on patch set 12 CR +1 V +1 02/25/26, 23:45
-
Georg Ringer voted on patch set 12 CR +2 V +2 02/26/26, 06:55
-
Georg Ringer merged patch set 13 02/26/26, 06:55