Review main Merged

85231[TASK] Update avatar component page in "Styleguide" backend module

Jasmina Ließmann CR +2 V +2 Normal +131 −19 updated 07/12/24, 14:01

Commit message

Naturally, ViewHelpers convert their contents immediately, which means
that in the examples of the "Styleguide" backend module, developers
only see the converted code and not the ViewHelper actually used. To
avoid this, code examples must use "non-intact" ViewHelpers. With this
patch, the CodeViewHelper is extended to decode transmitted entities.
As an example, the code examples on the "Avatar" component page have
been adapted accordingly.
In addition, the standard height in the CodeViewHelper's code mirror
configuration has been reduced.

Furthermore, new styling has been introduced for example uses and code
examples. This has also been adapted as an example on the "Avatar"
component page.

Finally, the texts on the "Avatar" component page have been updated.

Further adjustments to the other example pages in the "Styleguide"
backend module will follow.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 79

  1. Jasmina Ließmann uploaded patch set 1 07/11/24, 20:35

  2. core-ci voted on patch set 1 V +1 07/11/24, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61413

  3. Christian Kuhn commented on patch set 1 CR +1 V +1 07/11/24, 21:36

    Avatar.html:38

    this entity solution is a workaround for fluid since fluid does not allow to stop the parser. CDATA stuff is also no solution, since Fluid then *removes* the CDATA wrapped content in an early parsing step. that's ok for f:comment, but a problem here. the entity solution is already in use in other styleguide templates (e.g. Infobox.html), and i don't really like it, but i also see no other solution apart from extracting all 'example' code to .txt files and inlining the file content using a VH. this would also solve the issue, but is a maintenance nightmare due to the extracted files. as such, i'm fine with this.
  4. Jasmina Ließmann uploaded patch set 2 CR +1 V +1 07/12/24, 04:28

  5. core-ci voted on patch set 2 V +1 07/12/24, 04:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61441

  6. Christian Kuhn commented on patch set 2 CR +1 V +1 07/12/24, 13:43

    Avatar.html:38 Reply

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 07/12/24, 13:54

    Slick!
  8. Jasmina Ließmann voted on patch set 2 CR +2 V +2 07/12/24, 14:01

  9. Jasmina Ließmann merged patch set 3 07/12/24, 14:01