Review main Merged

85235[TASK] Properly set bcrypt cost

Christian Kuhn CR +2 V +2 Easy +5 −9 updated 07/12/24, 11:07

Commit message

BcryptPasswordHash has an option to set a cost
value. The lower barrier used to be identical
to PHP constant PASSWORD_BCRYPT_DEFAULT_COST.

Tests use the lower barrier to speed up tests.
With PHP <8.4, PASSWORD_BCRYPT_DEFAULT_COST is
10, it has been raised to 12 with PHP 8.4.

The patch frees our code from access to this
constant and hard codes 10 as lower barrier
check. This keeps the API as is, and this hash
is by default set to 12 already in default
options if none are provided.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 07/11/24, 23:33

  2. core-ci voted on patch set 1 V +1 07/11/24, 23:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61423

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 07/12/24, 09:18

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 07/12/24, 10:08

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 07/12/24, 11:07

  6. Christian Kuhn merged patch set 2 07/12/24, 11:07