Review 12.4 Merged

85241[TASK] Add distinct warning when CType element preview has no label

Christian Kuhn CR +2 V +2 Easy +8 −5 updated 07/12/24, 13:47

Commit message

When a CType content element is registered with an empty label,
the page preview of that element showed a warning:

  INVALID VALUE ("myPlugin")

which is actually misleading, because not the value itself is
wrong, but the label is missing.

A new language variable is introduced to distinguish the difference
of this misconfiguration issue, and now emits:

  MISSING LABEL ("myPlugin")

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 07/12/24, 10:01

  2. core-ci voted on patch set 1 V +1 07/12/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61473

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 07/12/24, 13:47

  4. Christian Kuhn merged patch set 2 07/12/24, 13:47