Review main Merged

85242[BUGFIX] Pass request in ext:form preview mode

Oli Bartsch CR +2 V +2 Easy +20 −6 updated 07/16/24, 07:18

Commit message

The ArrayFormFactory and underlying functionality
requires a PSR-7 Request object. In backend context,
when rendering the form element preview, the
request is now properly passed.

Additionally, the `RenderContentElementPreviewViewHelper`,
used in the preview mode to render the content
element preview initializes the PageLayoutContext,
which since #103326 also requires a PSR-7 Request.

Both places are adjusted accordingly, resolving the
TypeErrors and making the form preview working again.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 911

  1. Oli Bartsch uploaded patch set 1 07/12/24, 10:41

  2. core-ci voted on patch set 1 V -1 07/12/24, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61474

  3. Oli Bartsch uploaded patch set 2 V -1 07/12/24, 10:52

  4. core-ci voted on patch set 2 V +1 07/12/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61475

  5. Christian Kuhn commented on patch set 2 07/12/24, 11:12

    ArrayFormFactory.php:101

    why make this nullable? that's a protected method and build() properly hands the request over.
  6. Oli Bartsch commented on patch set 2 07/12/24, 12:14

    ArrayFormFactory.php:101 Reply

    $request might be NULL in build()
  7. Elias Häußler voted on patch set 2 V +1 07/13/24, 14:36

  8. Georg Ringer voted on patch set 2 CR +1 V +1 07/15/24, 12:24

  9. Jochen Roth voted on patch set 2 CR +1 07/16/24, 07:03

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 07/16/24, 07:18

  11. Oli Bartsch merged patch set 3 07/16/24, 07:18