Review 12.4 Merged

85243[TASK] Use ISO8601 dates in FormEngine datetime handling

Benjamin Franzke CR +2 V +2 Hard +206 −344 updated 07/19/24, 08:54

Commit message

Historically, FormEngine UI mangles dates from one format to another and
feeds the result back to the date picker, crossing fingers nothing goes
wrong. This bites hard when it comes to non-standard date formats,
basically everything but `d-m-Y`.

To lay the groundwork on tackling the date format issue, FormEngine now
always works with ISO8601 dates internally, allowing to get rid of some
helper methods.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1115

  1. Benjamin Franzke uploaded patch set 1 07/12/24, 12:55

  2. core-ci voted on patch set 1 V +1 07/12/24, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61484

  3. Benjamin Franzke voted on patch set 1 V -1 07/12/24, 13:08

  4. Benjamin Franzke voted on patch set 1 CR +1 V +1 07/12/24, 13:14

  5. Benjamin Franzke uploaded patch set 2 CR +1 V +1 07/12/24, 19:07

  6. core-ci voted on patch set 2 V +1 07/12/24, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61508

  7. Benjamin Franzke marked it work in progress 07/15/24, 05:38

  8. Benjamin Franzke uploaded patch set 3 V +1 07/15/24, 06:11

  9. Benjamin Franzke commented on patch set 3 CR +1 V +1 07/15/24, 06:17

    This change is ready for review.
  10. core-ci voted on patch set 3 V -1 07/15/24, 06:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61571

  11. Benjamin Franzke uploaded patch set 4 CR +1 V +1 07/15/24, 06:39

  12. Benjamin Franzke voted on patch set 4 CR +1 V +1 07/15/24, 06:39

  13. core-ci voted on patch set 4 V +1 07/15/24, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61572

  14. Andreas Kienast voted on patch set 4 CR +2 V +2 07/19/24, 08:54

  15. Andreas Kienast merged patch set 5 07/19/24, 08:54