85250[TASK] Add test for RecordIdentityMap
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/core/Classes/Domain/Persistence/RecordIdentityMap.php+7 −7
- typo3/sysext/core/Tests/Unit/Domain/Persistence/RecordIdentityMapTest.phpnew+58 −0
- typo3/sysext/frontend/Classes/Content/RecordCollector.php+3 −0
- typo3/sysext/frontend/Classes/DataProcessing/PageContentFetchingProcessor.php+1 −0
Review log 810
-
Oli Bartsch uploaded patch set 1 07/12/24, 15:41
-
core-ci voted on patch set 1 V +1 07/12/24, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61493
-
Benni Mack voted on patch set 1 CR +1 V +1 07/12/24, 19:26
-
Christian Kuhn voted on patch set 1 CR +1 V +1 07/15/24, 10:31
-
Christian Kuhn commented on patch set 1 CR -1 07/15/24, 10:32
please add a "Related" to the recent patch that introduced RecordIdentityMap. -
Benni Mack updated the commit message in patch set 2
CR +1V +107/15/24, 12:25 -
Benni Mack commented on patch set 2 CR +1 V +1 07/15/24, 12:25
Reply
Done -
core-ci voted on patch set 2 V +1 07/15/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61584
-
Georg Ringer voted on patch set 2 CR +2 V +2 07/15/24, 12:37
-
Georg Ringer merged patch set 3 07/15/24, 12:37