Review main Abandoned

85254[FEATURE] Add RateLimiter to FileDumpController

Georg Ringer CR 0 V 0 Easy +34 −0 updated 03/31/25, 19:01

Commit message

The rate limitation makes it harder to test for valid tokens to get
access to files delivered through the FileDumpController.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 46

  1. Georg Ringer uploaded patch set 1 07/12/24, 17:13

  2. core-ci voted on patch set 1 V +1 07/12/24, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61500

  3. Georg Ringer uploaded patch set 2 V +1 07/14/24, 05:34

  4. core-ci voted on patch set 2 V +1 07/14/24, 05:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61557

  5. Jan Kornblum commented on patch set 2 CR +1 V +1 07/14/24, 12:40

    Thank you very much! Would it be nice to use $GLOBALS['TYPO3_CONF_VARS']['BE']['loginRateLimit***'] (or its FE equivalent) here, or else introduce something like $GLOBALS['TYPO3_CONF_VARS']['eID']['fileDump']['tokenRateLimit***']? Or would that be overdosed?
  6. Georg Ringer abandoned the change 03/31/25, 19:01