Review main Merged

85256[TASK] Flush page cache after editing a form

Guido Schmechel CR +2 V +2 Easy +29 −0 updated 03/24/25, 19:17

Commit message

If a form is edited via the form editor the cache of the page
where it is referenced will be flushed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jasmina Ließmann +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Guido Schmechel uploaded patch set 1 07/14/24, 16:25

  2. core-ci voted on patch set 1 V +1 07/14/24, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61558

  3. Guido Schmechel commented on patch set 1 07/14/24, 16:36

    To clearify: Is it a task or more a feature? One way or another, something has to happen here. Either a customised release line or the missing RST. The code is largely based on existing code, so a task would be fine for me.
  4. Georg Ringer voted on patch set 1 CR +1 V +1 07/23/24, 09:27

  5. Benni Mack commented on patch set 1 08/09/24, 16:11

    Reply

    Hey Guido, this is a task

    FormEditorController.php:695

    why is this iterated by reference? I guess we can just write "foreach($referenceRows as $referenceRow)"

    FormEditorController.php:720

    why wrap this is in an extra method? We could just use BackendUtility::getRecord() above, right?
  6. Guido Schmechel commented on patch set 1 CR -1 08/10/24, 11:39

    FormEditorController.php:695 Reply

    Copy & paste from elsewhere. I'll change it.

    FormEditorController.php:720 Reply

    Here too: I had orientated myself on the original code. I assume it was about tests.
  7. Guido Schmechel uploaded patch set 2 CR +1 V +1 08/17/24, 10:28

  8. core-ci voted on patch set 2 V -1 08/17/24, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63637

  9. Guido Schmechel uploaded patch set 3 V -1 08/17/24, 10:40

  10. core-ci voted on patch set 3 V +1 08/17/24, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63638

  11. Guido Schmechel commented on patch set 3 08/17/24, 10:50

    FormEditorController.php:695 Reply

    Done

    FormEditorController.php:720 Reply

    Done
  12. Guido Schmechel uploaded patch set 4 V +1 01/19/25, 14:47

  13. core-ci voted on patch set 4 V +1 01/19/25, 14:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72678

  14. Benni Mack voted on patch set 4 CR +1 V +1 02/01/25, 20:37

  15. Jasmina Ließmann voted on patch set 4 CR +1 02/17/25, 11:29

  16. Georg Ringer voted on patch set 4 CR +2 V +2 03/24/25, 19:17

  17. Georg Ringer merged patch set 5 03/24/25, 19:17