85257[TASK] Avoid console error in hotkey module
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Guido Schmechel +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Guido Schmechel +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1214
-
Benjamin Franzke uploaded patch set 1 07/15/24, 07:31
-
core-ci voted on patch set 1 V +1 07/15/24, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61573
-
Andreas Kienast commented on patch set 1 07/15/24, 07:46
-
Benjamin Franzke commented on patch set 1 07/15/24, 09:34
hotkeys.ts:161Replythought about that as well, but then I thought: What if we want to support sequences at some point, then this kind of event should stop the sequence, so it's "good" to report "something" (=passthrough undefined). But I don't care, we can also additionally check the value, afterwards, but this method needs to be explicit about the possibly undefined property (in order to have one less strictNullChecks, out of 2499 – see 67256: [WIP][TASK] Enable TypeScript strictNullChecks | https://review.typo3.org/c/Packages/TYPO3.CMS/+/67256 😁) -
Andreas Kienast commented on patch set 1 CR +1 09/24/24, 10:20
hotkeys.ts:161ReplyAcknowledged -
Guido Schmechel commented on patch set 1 CR +1 V +1 10/03/24, 08:38
Tested in the forms module via search field and with chrome -
Garvin Hicking voted on patch set 1 CR +1 V +1 10/03/24, 09:38
-
Benjamin Franzke uploaded patch set 2
CR +1V +110/03/24, 11:53 -
Benjamin Franzke commented on patch set 2 10/03/24, 11:53
Sorry, had to repush, since I was not aware that hotkey.ts was main only. -
core-ci voted on patch set 2 V +1 10/03/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67007
-
Garvin Hicking voted on patch set 2 CR +1 V +1 10/03/24, 13:43
-
Guido Schmechel voted on patch set 2 CR +1 V +1 10/03/24, 14:10
-
Benjamin Franzke voted on patch set 2 CR +2 V +2 10/03/24, 15:38
-
Benjamin Franzke merged patch set 3 10/03/24, 15:39
hotkeys.ts:161