Review main Merged

85258[TASK] Disable unneeded livereload server in grunt-watch

Benjamin Franzke CR +2 V +2 Easy +0 −3 updated 07/15/24, 09:38

Commit message

Do not listen on the livereload port, as we do not ship
the client-side[1] livereload integration anyway.

This allows multiple grunt-watch (e.g. main and 12.4) to run
in parallel instead of blocking each other because they try
to allocate the same port.

[1] https://github.com/gruntjs/grunt-contrib-watch/blob/main/docs/watch-examples.md#enabling-live-reload-in-your-html

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Benjamin Franzke uploaded patch set 1 07/15/24, 07:49

  2. Benjamin Franzke updated the commit message in patch set 2 07/15/24, 07:50

  3. core-ci voted on patch set 1 V +1 07/15/24, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61574

  4. core-ci voted on patch set 2 V +1 07/15/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61575

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 07/15/24, 08:00

  6. Benni Mack voted on patch set 2 CR +1 V +1 07/15/24, 08:18

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 07/15/24, 09:24

  8. Andreas Kienast merged patch set 3 07/15/24, 09:38