Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

85262[POC][TASK] Apply locale specific format to date/time fields

Benjamin Franzke CR 0 V -1 Normal +141 −26 updated 10/18/24, 22:34

Commit message

This is an alternative to explicit configuration as in
https://review.typo3.org/c/Packages/TYPO3.CMS/+/84880.
Not yet decided which "route" we want, this is just an explorative
demo for now, as we can not parse locale-specific dates and therefore
need to disable direct editing in this context.

TODO:

 * We can not parse a locale-specific date. There are also no
   good workarounds – see https://stackoverflow.com/q/64569438.
   We need to fix flatpickr to not reparse dates and make
   the text-input similar to our link fields a readonly field that
   needs to be swapped into raw-mode for raw editing, as suggested
   by https://stackoverflow.com/questions/64569438/how-parse-a-date-string-generated-from-intl-datetimeformat#comment114206740_64569438
 * Or provide a switcher and support ddmmyy format in there?

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/85262/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/85262/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 1

Files 9

Review log 36

  1. Benjamin Franzke uploaded patch set 1 07/16/24, 08:19

  2. core-ci voted on patch set 1 V -1 07/16/24, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61616

  3. Benjamin Franzke uploaded patch set 2 V -1 07/16/24, 09:55

  4. core-ci voted on patch set 2 V -1 07/16/24, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61622

  5. Benni Mack updated the commit message in patch set 3 V -1 10/18/24, 13:38

  6. core-ci voted on patch set 3 V -1 10/18/24, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68012