85264[TASK] Make IconFactory a stateless service
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Georg Ringer +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Imaging/IconFactory.php+35 −91
- typo3/sysext/core/Classes/Imaging/IconRegistry.php+1 −4
- typo3/sysext/core/Classes/ServiceProvider.php2+7 −0
- typo3/sysext/core/Configuration/Services.yaml+2 −7
- typo3/sysext/core/Tests/Functional/Hooks/TcaItemsProcessorFunctionsTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Imaging/IconTest.php+2 −1
- typo3/sysext/core/Tests/UnitDeprecated/Imaging/IconTest.php+2 −1
Review log 1217
-
Christian Kuhn uploaded patch set 1 07/16/24, 09:03
-
core-ci voted on patch set 1 V +1 07/16/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61619
-
Christian Kuhn uploaded patch set 2
V +107/16/24, 09:46 -
core-ci voted on patch set 2 V -1 07/16/24, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61620
-
Christian Kuhn updated the commit message in patch set 3
V -107/16/24, 09:55 -
Christian Kuhn uploaded patch set 4 07/16/24, 10:01
-
core-ci voted on patch set 4 V +1 07/16/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61623
-
core-ci voted on patch set 3 V -1 07/16/24, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61621
-
Benjamin Franzke commented on patch set 4 07/16/24, 10:08
-
Christian Kuhn uploaded patch set 5
V +107/16/24, 10:12 -
Christian Kuhn commented on patch set 4 07/16/24, 10:12
ServiceProvider.php:332Replyoh. good point. done. thx. -
Benjamin Franzke voted on patch set 5 CR +1 07/16/24, 10:14
-
core-ci voted on patch set 5 V +1 07/16/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61626
-
Benjamin Franzke voted on patch set 5 V +1 07/16/24, 11:48
-
Georg Ringer voted on patch set 5 CR +1 V +1 07/16/24, 11:54
-
Christian Kuhn voted on patch set 5 CR +2 V +2 07/16/24, 11:58
-
Christian Kuhn merged patch set 6 07/16/24, 11:58
ServiceProvider.php:332