Review main Merged

85264[TASK] Make IconFactory a stateless service

Christian Kuhn CR +2 V +2 Normal +54 −109 updated 07/16/24, 11:58

Commit message

Get rid of a static class property by substituting
it with 'cache.runtime'. IconFactory is used in
ext:install and in early TCA building, a bit of
DI trickery is needed to to have 'cache.runtime'
available early.

Other class properties are general DI
modernization, two further properties are
just indirect access to TYPO3_CONF_VARS
and now inlined.

Have some minor method signature type additions
along the way. Those are not considered breaking
since consumers not feeding correct types would
already trigger errors in many cases from detail
code of the method implementations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1217

  1. Christian Kuhn uploaded patch set 1 07/16/24, 09:03

  2. core-ci voted on patch set 1 V +1 07/16/24, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61619

  3. Christian Kuhn uploaded patch set 2 V +1 07/16/24, 09:46

  4. core-ci voted on patch set 2 V -1 07/16/24, 09:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61620

  5. Christian Kuhn updated the commit message in patch set 3 V -1 07/16/24, 09:55

  6. Christian Kuhn uploaded patch set 4 07/16/24, 10:01

  7. core-ci voted on patch set 4 V +1 07/16/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61623

  8. core-ci voted on patch set 3 V -1 07/16/24, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61621

  9. Benjamin Franzke commented on patch set 4 07/16/24, 10:08

    ServiceProvider.php:332

    `$container->get('cache.runtime')` in order to use the shared instance.
  10. Christian Kuhn uploaded patch set 5 V +1 07/16/24, 10:12

  11. Christian Kuhn commented on patch set 4 07/16/24, 10:12

    ServiceProvider.php:332 Reply

    oh. good point. done. thx.
  12. Benjamin Franzke voted on patch set 5 CR +1 07/16/24, 10:14

  13. core-ci voted on patch set 5 V +1 07/16/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61626

  14. Benjamin Franzke voted on patch set 5 V +1 07/16/24, 11:48

  15. Georg Ringer voted on patch set 5 CR +1 V +1 07/16/24, 11:54

  16. Christian Kuhn voted on patch set 5 CR +2 V +2 07/16/24, 11:58

  17. Christian Kuhn merged patch set 6 07/16/24, 11:58