Review main Merged

85269[TASK] Streamline checkbox styling

Benjamin Kott CR +2 V +2 Hard +500 −118 updated 07/17/24, 11:23

Commit message

- Ensure correct markup structure checkboxes
- Add indeterminate state to `.form-check-type-icon-toggle`
- Add indeterminate state to `.form-check-type-toggle`
- Add indeterminate state to `.form-switch`
- Adjust alignment for `.form-check-type-toggle`
- Restore btn-check behaviour
- Introduce btn-block-vertical
- Make checkboxes focusable in localization wizard
- Add checkbox styling in localization wizard
- Add checkbox overview to styleguide
- Add `<UNIQUEID>` marker to styleguide code viewhelper

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 813

  1. Benjamin Kott uploaded patch set 1 07/16/24, 13:56

  2. core-ci voted on patch set 1 V -1 07/16/24, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61644

  3. Benjamin Kott uploaded patch set 2 V -1 07/17/24, 06:31

  4. Benjamin Kott uploaded patch set 3 07/17/24, 06:34

  5. core-ci voted on patch set 3 V -1 07/17/24, 06:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61676

  6. core-ci voted on patch set 2 V -1 07/17/24, 06:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61675

  7. Benjamin Kott uploaded patch set 4 V -1 07/17/24, 07:21

  8. core-ci voted on patch set 4 V -1 07/17/24, 07:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61677

  9. Benjamin Kott uploaded patch set 5 V -1 07/17/24, 08:42

  10. core-ci voted on patch set 5 V +1 07/17/24, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61679

  11. Andreas Kienast voted on patch set 5 CR +1 V +1 07/17/24, 09:50

  12. Benjamin Franzke commented on patch set 5 CR +2 V +2 07/17/24, 11:23

    Checkboxes.html:26

    Very good overview, thanks!
  13. Benjamin Franzke merged patch set 6 07/17/24, 11:23