Review main Abandoned

85272[BUGFIX] Set mandatory field in CType 'header' of EXT:fluid_styled_content

Christian Rath-Ulrich CR 0 V 0 Easy +7 −0 updated 08/06/24, 12:41

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1217

  1. Christian Rath-Ulrich uploaded patch set 1 07/17/24, 01:32

  2. core-ci voted on patch set 1 V -1 07/17/24, 01:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61657

  3. Georg Ringer commented on patch set 1 CR -1 07/17/24, 05:13

    on this place you would just set it required for every content element which is of course breaking and not desired. if you change it for the header ctype only, we can discuss that but would be main branch only and needs an important rst!
  4. Mathias Brodala commented on patch set 1 07/17/24, 07:03

    Reply

    AFAIK this is not possible at all. You can use "columnsOverrides" but this can only adjust rendering, not data processing. And marking a field as required is data processing.
  5. Jasmina Ließmann uploaded patch set 2 CR -1 V -1 07/18/24, 17:41

  6. Jasmina Ließmann updated the commit message in patch set 3 07/18/24, 17:41

  7. Jasmina Ließmann commented on patch set 3 07/18/24, 17:44

    Reply

    The 'header' field is now only a mandatory field in CType 'header'. I have also adjusted the commit message, as this adjustment should only be made for main. An rst file is still missing.
  8. core-ci voted on patch set 2 V +1 07/18/24, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61754

  9. core-ci voted on patch set 3 V -1 07/18/24, 17:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61755

  10. core-ci voted on patch set 3 V +1 07/18/24, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61755

  11. Georg Ringer voted on patch set 3 CR +1 V +1 07/19/24, 06:30

  12. Jasmina Ließmann uploaded patch set 4 CR +1 V +1 07/19/24, 06:36

  13. core-ci voted on patch set 4 V +1 07/19/24, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61786

  14. Jasmina Ließmann commented on patch set 4 CR -1 07/19/24, 06:43

    Reply

    Since the ticket refers to the output of EXT:fluid_styled_content, but not every installation uses this extension for its frontend output, I have moved the configuration to EXT:fluid_styled_content. I am still unsure whether the patch is really suitable, since the following settings are checked in Fluid Partial of EXT:fluid_styled_content: ``` <f:if condition="{data.header_layout} != 100"> <f:if condition="{data.header} || {data.subheader} || {data.date}"> ``` This means that the "header" field is not exclusively responsible for the successful rendering of this content element in the frontend. One of the fields "subheader" or "date" can also be filled in just as well. In addition, no other field in EXT:frontend or EXT:fluid_styled_content is marked as a required field. I therefore tend to discard the patch and leave it to the integrators of each project to decide which fields should really be mandatory.
  15. Oli Bartsch commented on patch set 4 07/19/24, 06:59

    Reply Unresolved

    Generally I always in for adding such requirements to prevent "[No Title]" elements. However, I also think we should not introduce this for this CType now. Let's work on content blocks integration and TcaSchema first and see if we can manage to implement such settings afterwards.
  16. Christian Kuhn commented on patch set 4 08/06/24, 12:41

    hey. i'll go ahead and will abandon this approach: it can not find consensus since it is too breaking. i hope that is ok.
  17. Christian Kuhn abandoned the change 08/06/24, 12:41