Review main Merged

85277[TASK] Add "Page Content:Type" in BE user information module

Georg Ringer CR +2 V +2 Easy +36 −0 updated 08/05/24, 19:16

Commit message

The information about the allowed content types (typically CType) has
been added to the user information in the beuser module.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • Sebastian Klein +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Riccardo De Contardi +1
    • Christian Kuhn +1
    • Sebastian Klein +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1113

  1. Georg Ringer uploaded patch set 1 07/17/24, 13:19

  2. Georg Ringer commented on patch set 1 07/17/24, 13:19

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 07/17/24, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61687

  4. Sebastian Klein voted on patch set 1 CR +1 V +1 08/01/24, 18:36

  5. Andreas Kienast commented on patch set 1 CR -1 08/01/24, 18:59

    UserInformationService.php:239

    Exploding an empty string leads to an array containing an empty string as its single element and may cause funny issues. I'd rather explicitly check whether the array key exists.
  6. Georg Ringer uploaded patch set 2 CR +1 V +1 08/01/24, 19:02

  7. core-ci voted on patch set 2 V +1 08/01/24, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62613

  8. Andreas Kienast commented on patch set 2 CR +1 V +1 08/01/24, 19:19

    UserInformationService.php:239 Reply

    Done
  9. Riccardo De Contardi commented on patch set 2 V +1 08/04/24, 16:27

    Tested on latest main
  10. Christian Kuhn voted on patch set 2 CR +1 V +1 08/05/24, 09:30

  11. Sebastian Klein voted on patch set 2 CR +1 V +1 08/05/24, 17:27

  12. Georg Ringer voted on patch set 2 CR +2 V +2 08/05/24, 19:16

  13. Georg Ringer merged patch set 3 08/05/24, 19:16