85277[TASK] Add "Page Content:Type" in BE user information module
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- Sebastian Klein +1
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Riccardo De Contardi +1
- Christian Kuhn +1
- Sebastian Klein +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/beuser/Classes/Service/UserInformationService.php2+10 −0
- typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html+15 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+8 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Show.html+3 −0
Review log 1113
-
Georg Ringer uploaded patch set 1 07/17/24, 13:19
-
Georg Ringer commented on patch set 1 07/17/24, 13:19
This change is ready for review. -
core-ci voted on patch set 1 V +1 07/17/24, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61687
-
Sebastian Klein voted on patch set 1 CR +1 V +1 08/01/24, 18:36
-
Andreas Kienast commented on patch set 1 CR -1 08/01/24, 18:59
UserInformationService.php:239Exploding an empty string leads to an array containing an empty string as its single element and may cause funny issues. I'd rather explicitly check whether the array key exists. -
Georg Ringer uploaded patch set 2
CR +1V +108/01/24, 19:02 -
core-ci voted on patch set 2 V +1 08/01/24, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62613
-
Andreas Kienast commented on patch set 2 CR +1 V +1 08/01/24, 19:19
UserInformationService.php:239ReplyDone -
Riccardo De Contardi commented on patch set 2 V +1 08/04/24, 16:27
Tested on latest main -
Christian Kuhn voted on patch set 2 CR +1 V +1 08/05/24, 09:30
-
Sebastian Klein voted on patch set 2 CR +1 V +1 08/05/24, 17:27
-
Georg Ringer voted on patch set 2 CR +2 V +2 08/05/24, 19:16
-
Georg Ringer merged patch set 3 08/05/24, 19:16