85279[BUGFIX] Use button-tags for the control-buttons of sortable select items
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 6
- Build/Sources/TypeScript/backend/form-engine/element/abstract-sortable-select-items.ts+2 −7
- typo3/sysext/backend/Classes/Form/Element/FolderElement.php+15 −10
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+15 −10
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+15 −10
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/abstract-sortable-select-items.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsGroupCest.php+6 −6
Review log 1725
-
Ayke Halder uploaded patch set 1 07/17/24, 16:02
-
core-ci voted on patch set 1 V +1 07/17/24, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61700
-
Ayke Halder voted on patch set 1 CR +1 V +1 07/17/24, 16:24
-
Ayke Halder updated the commit message in patch set 2
CR +1V +107/17/24, 17:10 -
Ayke Halder updated the commit message in patch set 3 07/17/24, 17:12
-
core-ci voted on patch set 2 V +1 07/17/24, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61701
-
core-ci voted on patch set 3 V -1 07/17/24, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61702
-
core-ci voted on patch set 3 V +1 07/18/24, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61702
-
Benjamin Kott commented on patch set 3 CR -1 07/18/24, 07:12
on it -
Benjamin Kott uploaded patch set 4
CR -1V +107/18/24, 07:33 -
Benjamin Kott commented on patch set 4 07/18/24, 07:34
Reply
Done -
core-ci voted on patch set 4 V -1 07/18/24, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61723
-
Benjamin Kott uploaded patch set 5
V -107/18/24, 07:45 -
core-ci voted on patch set 5 V +1 07/18/24, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61724
-
Andreas Kienast voted on patch set 5 CR +1 V +1 07/18/24, 07:57
-
Benjamin Kott updated the commit message in patch set 6
CR +1V +107/18/24, 08:03 -
Ayke Halder commented on patch set 5 CR -1 V -1 07/18/24, 08:05
`button`-tags need `type="button"` - otherwise they are automatically `type="submit"`. -
Benjamin Kott commented on patch set 6 07/18/24, 08:06
Reply
agree, missed that - on it -
Benjamin Kott uploaded patch set 7 07/18/24, 08:09
-
Benjamin Kott commented on patch set 7 07/18/24, 08:10
Reply
Done -
core-ci voted on patch set 6 V -1 07/18/24, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61728
-
core-ci voted on patch set 7 V +1 07/18/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61731
-
Benjamin Kott voted on patch set 7 CR +1 V +1 07/18/24, 08:18
-
Andreas Kienast voted on patch set 7 CR +2 V +2 07/18/24, 08:18
-
Andreas Kienast merged patch set 8 07/18/24, 08:18