Review main Merged

85279[BUGFIX] Use button-tags for the control-buttons of sortable select items

Ayke Halder CR +2 V +2 Normal +54 −44 updated 07/18/24, 08:18

Commit message

This patch corrects the missusage of anchor elements instead of buttons
for controlling sortable selects. In addition we are adding the existing
labels to the buttons to support visually impaired users.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1725

  1. Ayke Halder uploaded patch set 1 07/17/24, 16:02

  2. core-ci voted on patch set 1 V +1 07/17/24, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61700

  3. Ayke Halder voted on patch set 1 CR +1 V +1 07/17/24, 16:24

  4. Ayke Halder updated the commit message in patch set 2 CR +1 V +1 07/17/24, 17:10

  5. Ayke Halder updated the commit message in patch set 3 07/17/24, 17:12

  6. core-ci voted on patch set 2 V +1 07/17/24, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61701

  7. core-ci voted on patch set 3 V -1 07/17/24, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61702

  8. core-ci voted on patch set 3 V +1 07/18/24, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61702

  9. Benjamin Kott commented on patch set 3 CR -1 07/18/24, 07:12

    on it
  10. Benjamin Kott uploaded patch set 4 CR -1 V +1 07/18/24, 07:33

  11. Benjamin Kott commented on patch set 4 07/18/24, 07:34

    Reply

    Done
  12. core-ci voted on patch set 4 V -1 07/18/24, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61723

  13. Benjamin Kott uploaded patch set 5 V -1 07/18/24, 07:45

  14. core-ci voted on patch set 5 V +1 07/18/24, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61724

  15. Andreas Kienast voted on patch set 5 CR +1 V +1 07/18/24, 07:57

  16. Benjamin Kott updated the commit message in patch set 6 CR +1 V +1 07/18/24, 08:03

  17. Ayke Halder commented on patch set 5 CR -1 V -1 07/18/24, 08:05

    `button`-tags need `type="button"` - otherwise they are automatically `type="submit"`.
  18. Benjamin Kott commented on patch set 6 07/18/24, 08:06

    Reply

    agree, missed that - on it
  19. Benjamin Kott uploaded patch set 7 07/18/24, 08:09

  20. Benjamin Kott commented on patch set 7 07/18/24, 08:10

    Reply

    Done
  21. core-ci voted on patch set 6 V -1 07/18/24, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61728

  22. core-ci voted on patch set 7 V +1 07/18/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61731

  23. Benjamin Kott voted on patch set 7 CR +1 V +1 07/18/24, 08:18

  24. Andreas Kienast voted on patch set 7 CR +2 V +2 07/18/24, 08:18

  25. Andreas Kienast merged patch set 8 07/18/24, 08:18