Review 12.4 Merged

85282[BUGFIX] Use button-tags for the control-buttons of sortable select items

Andreas Kienast CR +2 V +2 Normal +54 −44 updated 07/18/24, 08:18

Commit message

This patch corrects the misusage of anchor elements instead of buttons
for controlling sortable selects. In addition we are adding the existing
labels to the buttons to support visually impaired users.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 6

Review log 58

  1. Andreas Kienast uploaded patch set 1 07/18/24, 08:01

  2. Benjamin Kott updated the commit message in patch set 2 07/18/24, 08:03

  3. core-ci voted on patch set 1 V +1 07/18/24, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61727

  4. Andreas Kienast uploaded patch set 3 07/18/24, 08:09

  5. core-ci voted on patch set 2 V -1 07/18/24, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61729

  6. core-ci voted on patch set 3 V +1 07/18/24, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61730

  7. Andreas Kienast voted on patch set 3 CR +2 V +2 07/18/24, 08:18

  8. Andreas Kienast merged patch set 4 07/18/24, 08:18